You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our app uses a TON of engines and in-repo addons. It would be great to detect when the build had files that weren't present in the config. Conversely, it would be great to also detect if there were config entries present that were not represented by real files.
It could be possible to implement this using fs-tree-diff, which would allow us to have human readable output indicating whether something was missing on one side or the other.
The text was updated successfully, but these errors were encountered:
It would be great to detect when the build had files that weren't present in the config
Not sure about this. The default config only covers .js and .css files, because these are the ones that get linked from the index.html file, and as such directly affect the loading time. But other files like images are not covered by default, as they might be loaded mostly on-demand (i.e. when visiting certain routes) and as such don't need to count against some size budget.
Your suggestion would treat those files as some kind of error, or what kind of detection did you have in mind?
Conversely, it would be great to also detect if there were config entries present that were not represented by real files.
Agree this can be useful, as this seems to be a sign of a misconfiguration...
I think we could narrow what we're detecting to .js and .css, as those are the types that we're actually concerned about. It would be fairly simple to cross reference this in the dist to determine what the list of files was.
Your suggestion would treat those files as some kind of error, or what kind of detection did you have in mind?
Yes, precisely. I think this only works if you have that sort of detection present. Otherwise, it's possible for people to add new files (think engines) without ensuring they're present in the config.
We've been running something very similar to this at LinkedIn in our flagship app. We have ~100 in repo addons and engines, so you can imagine it's pretty gnarly to deal with.
Our app uses a TON of engines and in-repo addons. It would be great to detect when the build had files that weren't present in the config. Conversely, it would be great to also detect if there were config entries present that were not represented by real files.
It could be possible to implement this using fs-tree-diff, which would allow us to have human readable output indicating whether something was missing on one side or the other.
The text was updated successfully, but these errors were encountered: