Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor improvement: renaming of methods #6

Open
ITernovtsii opened this issue Aug 28, 2015 · 3 comments
Open

minor improvement: renaming of methods #6

ITernovtsii opened this issue Aug 28, 2015 · 3 comments

Comments

@ITernovtsii
Copy link

Looks like we can just use "build" and "buildByContentIds" functions because eZObjectWrapperFactory should build only eZObjectWrapper and factory name is ok to describe it :)

@ITernovtsii ITernovtsii changed the title minor improvement: renaming of methods buildeZObjectWrapper and buildeZObjectWrappersByContentIds minor improvement: renaming of methods Aug 28, 2015
@gggeek
Copy link
Contributor

gggeek commented Aug 28, 2015

or even better: buildOne :-) and buildMany() :-)

@gggeek
Copy link
Contributor

gggeek commented Aug 28, 2015

Otoh buildOne should not accept a numeric id - as the ID might be either a Content or a Location.

I'd go for:

build -> takes Object or Location
buildByContent -> takes Content or content Id
buldbyLocation -> takes Location or location id
buildManyByContent
buildManyByLocation

@gggeek
Copy link
Contributor

gggeek commented Oct 26, 2015

PR for v3 sent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants