Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor context related elements #1042

Open
4 of 8 tasks
cnouguier opened this issue Jan 13, 2025 · 0 comments
Open
4 of 8 tasks

Refactor context related elements #1042

cnouguier opened this issue Jan 13, 2025 · 0 comments
Assignees
Labels
core Issue affecting core module enhancement
Milestone

Comments

@cnouguier
Copy link
Contributor

cnouguier commented Jan 13, 2025

  • The core module must intiailizes the Store if a context is defined in the configuration
  • It must relies on the Store to store the current context
  • It must provide a composable that helps using the current context
  • Remove mixin.base-context.js
  • Replace the contextId props with a service prop which can be either a string (id) or an object (name and context)
  • Remove unrequired contextId prop when the context should be directly extracted from the store (e.g. map)
  • Add a getService(name, 'context') in API when we'd like to explicitely retrieve the current context from the store instead of doing this implicitely when no context is given, when no context is given we should get the global service
  • Remove declareService() as it should not be useful anymore with the previous change
@cnouguier cnouguier added enhancement core Issue affecting core module labels Jan 13, 2025
@cnouguier cnouguier added this to the v2.5.x milestone Jan 13, 2025
@cnouguier cnouguier self-assigned this Jan 13, 2025
@claustres claustres moved this from To do to In progress in KDK Roadmap Jan 16, 2025
@claustres claustres changed the title Refactor mixin.base-context Refactor context related elements Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issue affecting core module enhancement
Projects
Status: In progress
Development

No branches or pull requests

1 participant