Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 9 #377

Open
willrogers opened this issue May 2, 2018 · 2 comments
Open

Java 9 #377

willrogers opened this issue May 2, 2018 · 2 comments

Comments

@willrogers
Copy link

willrogers commented May 2, 2018

There are a few tweaks for Java 9, most of which I have done.

There's only one problem I can find: com.sun.javafx.tk.FontMetrics has removed its computeStringWidth(String) method in favour of getCharWidth(char). It might be possible to do the same thing by simply summing the widths of the characters in the string.

This is relevant in GraphicsUtils.java.

@willrogers willrogers mentioned this issue May 2, 2018
@kasemir
Copy link
Owner

kasemir commented May 2, 2018

Note that all the display builder Java 9 changes are already in the phoebus version.
The basic problem is that you can't do this type of JavaFX code for both Java 8 and Java 9.

@willrogers
Copy link
Author

Sure - you can merge this (or not) at the time of your choice, probably once CS-Studio is fully moved across to Java 9 so there's no reason to keep this on Java 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants