Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: per prompt target is ignored and system prompt is getting used instead #369

Open
adilhafeez opened this issue Jan 16, 2025 · 1 comment · Fixed by #368
Open

bug: per prompt target is ignored and system prompt is getting used instead #369

adilhafeez opened this issue Jan 16, 2025 · 1 comment · Fixed by #368
Assignees
Labels
bug Something isn't working

Comments

@adilhafeez
Copy link
Contributor

adilhafeez commented Jan 16, 2025

Per system prompt is getting ignored and system prompt is used for all prompts.

@adilhafeez adilhafeez self-assigned this Jan 16, 2025
@adilhafeez adilhafeez added the bug Something isn't working label Jan 16, 2025
@adilhafeez
Copy link
Contributor Author

adilhafeez commented Jan 16, 2025

Fix is in #368 but testing is manual until mock out upstream llm. For now here is how I have verified this code change,

  1. start currency exchange demo
  2. start model server in foreground
    $ archgw up --service model_server --foreground
    
  3. start archgw from currency exchange in foreground
    $ archgw up --service archgw --foreground
    
  4. send following rest request to arch gateway,
    $ curl --header 'Content-Type: application/json' \
      --data '{"messages": [{"role": "user","content": "can you please convert 100 jpy"}]}' \
      http://localhost:10000/v1/chat/completions"
    
  5. after the request complete head over to archgw console logs and look for line archgw => llm request. There you should see system prompt with message You are a helpful assistant. Show me the currency symbol you want to convert from USD.\n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant