Skip to content

Latest commit

 

History

History
106 lines (81 loc) · 4.58 KB

README.md

File metadata and controls

106 lines (81 loc) · 4.58 KB

Conventions for OSD operators written in Go

This convention is suitable for both cluster- and hive-deployed operators.

The following components are included:

make targets and functions.

Note: Your repository's main Makefile needs to be edited to include the "nexus makefile include":

include boilerplate/generated-includes.mk

One of the primary purposes of these make targets is to allow you to standardize your prow and app-sre pipeline configurations using the following:

Prow

Test name / make target Purpose
validate Ensure code generation has not been forgotten; and ensure generated and boilerplate code has not been modified.
lint Perform static analysis.
test "Local" unit and functional testing.
coverage Code coverage analysis and reporting.

To standardize your prow configuration, you may run:

$ make prow-config

If you already have the openshift/release repository cloned locally, you may specify its path via $RELEASE_CLONE:

$ make RELEASE_CLONE=/home/me/github/openshift/release prow-config

This will generate a delta configuring prow to:

  • Build your build/Dockerfile.
  • Run the above targets in presubmit tests.
  • Run the coverage target in a postsubmit. This is the step that updates your coverage report in codecov.io.

Local Testing

You can run these make targets locally during development to test your code changes. However, differences in platforms and environments may lead to unpredictable results. Therefore boilerplate provides a utility to run targets in a container environment that is designed to be as similar as possible to CI:

$ ./boilerplate/_lib/container-make {target}

app-sre

The build-push target builds and pushes the operator and OLM registry images, ready to be SaaS-deployed. By default it is configured to be run from the app-sre jenkins pipelines. Consult this doc for information on local execution/testing.

Code coverage

  • A codecov.sh script, referenced by the coverage make target, to run code coverage analysis per this SOP.

  • A .codecov.yml configuration file for codecov.io. Note that this is copied into the repository root, because that's where codecov.io expects it.

Linting and other static analysis with golangci-lint

  • A go-check make target, which
  • ensures the proper version of golangci-lint is installed, and
  • runs it against
  • a golangci.yml config.
  • a GOLANGCI_OPTIONAL_CONFIG config if it is defined and file exists

Checks on generated code

The convention embeds default checks to ensure generated code generation is current, committed, and unaltered. To trigger the check, you can use make generate-check provided your Makefile properly includes the boilerplate-generated include boilerplate/generated-includes.mk.

Checks consist of:

  • Checking all files are committed to ensure a safe point to revert to in case of error
  • Running the make generate command (see below) to regenerate the needed code
  • Checking if this results in any new uncommitted files in the git project or if all is clean.

make generate does the following:

  • generate crds and deepcopy via controller-gen. This is a no-op if your operator has no APIs.
  • openapi-gen. This is a no-op if your operator has no APIs.
  • go generate. This is a no-op if you have no //go:generate directives in your code.