-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The plugin should probably not depend on spring-core, spring-web, javax.ws.rs-api and javax.servlet-api #170
Comments
It's kept only for compiling tests See kbuntrock#170
I agree, reducing the surface of dependencies has some sweet advantages. As you mention, the only feature I'm using from Spring is the annotations resolver (I guess located in Spring core). Especially for their custom non standard alias mechanism. And probably for some inheritance resolving too. Ideally, getting rid of this part would be nice too, but it brings other problems. I have no idea yet if the spring annotation resolver internals are complex or not and if it worth to be re-implemented. Other than that, I see no issues getting rid of the other dependencies. |
It's kept only for compiling tests See #170
Excepted for the
MergedAnnotations
feature, most dependencies could probably be easily removed by replacing classes and enum import by String, e.g. inOperationType
:rather than:
This would lower required dependencies, and limit security surface.
And these dependencies should probably be just test dependencies.
The text was updated successfully, but these errors were encountered: