{x:Static} does not work for internal members in the same assembly.

[colejohnson66]

See AvaloniaUI/Avalonia#16929. According to @maxkatz6, {x:Static} should work on internal members if those members are in the same assembly. However, XamlX fails because it requires everything to be public:

XamlX/src/XamlX/Ast/Intrinsics.cs

Lines 116 to 118 in 7b8f609

	var member = type?.Fields.FirstOrDefault(f => f.IsPublic && f.IsStatic && f.Name == Member) ??
	(IXamlMember?)type?.GetAllProperties().FirstOrDefault(p =>
	p.Name == Member && p.Getter is { IsPublic: true, IsStatic: true });

[maxkatz6]

It should be a relatively simple fix + one unit test for anybody, who has time to take a look.
Once XamlX changes are merged, we can get it upstream in Avalonia.

[stevemonaco]

This has been more complicated than expected. I've implemented the feature locally (for static fields so far) and I've come across two problems:

1. trying to test by adding another TestCase here:

https://github.com/kekekeks/XamlX/blob/master/tests/XamlParserTests/IntrinsicsTests.cs#L89-L108

I've modified IntrinsicsTestsClass to include an internal static field which results in this exception:

System.FieldAccessException : Attempt by method 'TestXaml.88acbed1e31b4312990250a1e2bea46b.Populate(System.IServiceProvider, XamlParserTests.IntrinsicsTestsClass)' to access field 'XamlParserTests.IntrinsicsTestsClass.StaticInternalField' failed.

I suspect the issue is the .NET runtime failing because the type is within the test assembly (eg. CecilTests) and not the generated XAML assembly (TestAsm). Therefore internal access fails. Is there a straightforward way to include a class in the generated assembly?

2. There's a plumbing problem to ensure we're not fetching internal members from an external assembly. However, the call site at Intrinsics appears to lack knowledge of what assembly the to-be-generated XAML type will be in.

[maxkatz6]

I suspect the issue is the .NET runtime failing because the type is within the test assembly (eg. CecilTests) and not the generated XAML assembly (TestAsm).

For testing purposes, you can try to inject IgnoresAccessChecksTo attribute in the generated assembly.
We actually do that for Avalonia https://github.com/AvaloniaUI/Avalonia/blob/dccaea61a69280e7a91078ca089b9603f3fe6200/src/Markup/Avalonia.Markup.Xaml.Loader/AvaloniaXamlIlRuntimeCompiler.cs#L125

Ideally, it should only be limited by testing assemblies here.