-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spotify provider #16
Comments
@kellnerd What is the state here? Has someone already done some work for Spotify support? Would you mind if I'd give this a go? |
@RustyNova016 had expressed interest on the forums:
But no clear commitment so far, so I will assign the issue to you @phw. |
Some notes about the Track Relinking for future reference: For now this does not seem to affect the provider. The track relinking is only happening if requesting a track from the API with a specific market set. Otherwise no relinking is happening and the available markets are simply indicated with the Here are shortened replies for the example track
The result is a mix of the originally requested track and the actually returned track. That relinking happened is indicated by the {
"id": "4gNlDPuBlf3rxkxRaDTAvf",
"name": "Heaven and Hell",
"duration_ms": 243053,
"track_number": 7,
"linked_from": {
"external_urls": {
"spotify": "https://open.spotify.com/track/6kLCHFM39wkFjOuyPGLGeQ"
},
"href": "https://api.spotify.com/v1/tracks/6kLCHFM39wkFjOuyPGLGeQ",
"id": "6kLCHFM39wkFjOuyPGLGeQ",
"type": "track",
"uri": "spotify:track:6kLCHFM39wkFjOuyPGLGeQ"
},
"is_playable": true,
"external_ids": {
"isrc": "USLB11110086"
},
"external_urls": {
"spotify": "https://open.spotify.com/track/6kLCHFM39wkFjOuyPGLGeQ"
},
"uri": "spotify:track:4gNlDPuBlf3rxkxRaDTAvf",
"href": "https://api.spotify.com/v1/tracks/6kLCHFM39wkFjOuyPGLGeQ",
"preview_url": "https://p.scdn.co/mp3-preview/9ff410684525dec4e22c322ba38a9ca4f9a4cf1c?cid=cfe923b2d660439caf2b557b21f31221",
"type": "track"
} If doing the same request but without the {
"id": "6kLCHFM39wkFjOuyPGLGeQ",
"name": "Heaven and Hell",
"duration_ms": 243053,
"track_number": 7,
"available_markets": [],
"external_ids": {
"isrc": "USLB11110086"
},
"external_urls": {
"spotify": "https://open.spotify.com/track/6kLCHFM39wkFjOuyPGLGeQ"
},
"uri": "spotify:track:6kLCHFM39wkFjOuyPGLGeQ",
"href": "https://api.spotify.com/v1/tracks/6kLCHFM39wkFjOuyPGLGeQ",
"preview_url": "https://p.scdn.co/mp3-preview/9ff410684525dec4e22c322ba38a9ca4f9a4cf1c?cid=cfe923b2d660439caf2b557b21f31221",
"type": "track"
} The result now fully represents the requested track. Both |
And I still do! But this week and probably the next is quite a wild ride so I can't really do anything for now. |
@RustyNova016 Sorry if I got in the way. I was just very keen on having this tool to support Spotify, so I started right away. But please definitely take a look at Harmony if you want to improve something. I found it a pleasure to work with the code. It is really extensible, and I think already better in its current state than a-tisket. There is likely a lot that could and should be added, but with this codebase it will actually be doable :) |
Nah it's fine. With features like this the faster they are done, the better. Even more that I got other projects to work on. I did check the codebase a bit and it looks pretty clean, but without enough comments. Do want to get a docker environment started first before doing work still. |
Implement a Spotify provider based on the Spotify Web API.
Implementation notes:
/
.Related to #5
The text was updated successfully, but these errors were encountered: