Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current fetiche-engine design is hampering us #25

Open
keltia opened this issue Sep 14, 2023 · 4 comments
Open

Current fetiche-engine design is hampering us #25

keltia opened this issue Sep 14, 2023 · 4 comments
Assignees
Labels
bug Something isn't working design issue Something in wrong in the design work-in-progress

Comments

@keltia
Copy link
Owner

keltia commented Sep 14, 2023

The current design of Engine is blocking us from using it fully inside fetiched and it knows too much, some of its data is not at the right place. State management is included, some paths are complicated to override and some of it should move into separate actors.

@keltia keltia added bug Something isn't working design issue Something in wrong in the design labels Sep 14, 2023
@keltia keltia self-assigned this Sep 14, 2023
@keltia
Copy link
Owner Author

keltia commented Sep 14, 2023

We should have a separate storage actor, probably a statistics one and Config should be handling more.

@keltia
Copy link
Owner Author

keltia commented Sep 25, 2023

Separating into different actors is needed but not enough, the current Engine does really too many things. BTW storage actor is there BTW. We are hitting the limit of the current design which is an hybrid between library included in an executable like acutectl and just a part of fetiched. We may have to fork the entire fetiche-engine in the engine actor.

@keltia
Copy link
Owner Author

keltia commented Oct 2, 2023

fetiche-engine has been forked into acutectl for now and fetiched will incorporate the core of it (removing state, storage, etc. stuff). Fork done in f2d88ff.
Main take away: fetiched is engine at the core and all the actors are peripheral services. fetiche-sources might end up here as well.

@keltia
Copy link
Owner Author

keltia commented Oct 12, 2023

As of 3946751 , branch has been merged into develop so fetiched has a working trimmed-down version of Engine without storage & state management.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design issue Something in wrong in the design work-in-progress
Projects
None yet
Development

No branches or pull requests

1 participant