Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the shizuku support option to work with other root options like sui without forcing to install shizuku. #1372

Closed
1 task
ShoyebOP opened this issue Dec 24, 2024 · 1 comment
Closed
1 task

Make the shizuku support option to work with other root options like sui without forcing to install shizuku. #1372

ShoyebOP opened this issue Dec 24, 2024 · 1 comment
Assignees
@sds100
Labels
bug Something isn't working
Milestone
2.8

Comments

@ShoyebOP
Copy link

ShoyebOP commented Dec 24, 2024 •
edited
Loading

Developer TODO (don't remove)

  • update documentation

My device is rooted and I use this Sui magisk module to get shizuku features on shizuku supported apps.

Screenshot_20241224-114258_Key Mapper

As you can see the app sees this module as shizuku started but it doesn't allow it to run without shizuku installed. It does work after installing shizuku (without doing anything in shizuku).

So please remove the condition of being shizuku installed if step 2 is already done.
@ShoyebOP ShoyebOP added enhancement New feature or request needs triage labels Dec 24, 2024
@sds100 sds100 added bug Something isn't working and removed enhancement New feature or request needs triage labels Dec 24, 2024
@sds100 sds100 added this to the 2.8 milestone Dec 24, 2024
sds100 added a commit that referenced this issue Jan 4, 2025
@sds100
#1372 fix: show Shizuku as installed if it is started in case the use…
be38eb2 
…r is using Sui.
@sds100
Copy link
Collaborator

sds100 commented Jan 19, 2025

fixed

@sds100 sds100 closed this as completed Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sds100 sds100

Labels
bug Something isn't working
Projects
Key Mapper
Status: Done
Milestone
2.8
Development

No branches or pull requests
2 participants
@sds100 @ShoyebOP