Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation on resolution of PIDs may indicate errors in record due to non-resolvable fields #253

Open
Pfeil opened this issue Jan 2, 2025 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@Pfeil
Copy link
Member

Pfeil commented Jan 2, 2025

Is your feature request related to a problem? Please describe.

Resolving a PID with e.g. /api/v1/pit/pid/21.11152/474a4b1c-de93-4d4a-b33d-1d32d63baf4b?validation=true will fail because the record will contain a URL field.

This is because the URL field is currently considered interesting, and is returned by the HandleProcotol wrapper in the Typed PID Maker.

Describe the solution you'd like / consider

Either

a) make sure such fields are never returned
b) make sure such fields (which are not resolveable but part of the provider) are ignored while validation (at least when validating-on-resolution)

To be honest, b) sounds like it would complicate things. But we will need to discuss it.

Additional context

Searching for the PID will (as soon as the according branch is merged, which will soon be the case) lead you to a test case which can easily be modified to reproduce and analyze the issue.

@Pfeil Pfeil added enhancement New feature or request question Further information is requested labels Jan 2, 2025
@Pfeil Pfeil changed the title Validation on resolution of PIDs may fail due to non-resolvable fields Validation on resolution of PIDs may indicate errors in record due to non-resolvable fields Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant