Migrate HelpFragment to jetpack.

[MohitMaliFtechiz]

Parent Issue #2669

[jackq97]

Hello, i would like to take this issue and migrate the help fragment to jetpack compose screen . you can assign this issue to me.

[MohitMaliFtechiz]

@jackq97 Thanks for showing the interest. @SOUMEN-PAL requested to start working on this issue, @SOUMEN-PAL can you please confirm are you working on this issue?

[SOUMEN-PAL]

@jackq97 Thanks for showing the interest. @SOUMEN-PAL requested to start working on this issue, @SOUMEN-PAL can you please confirm are you working on this issue?

Yes I am working on the problem.
I have sorted out the changes with the ui and regarding the viewmodel for proper migration.
If needed I can also update the XML to be compatible with compossable retaining the XML addons.

[MohitMaliFtechiz]

@SOUMEN-PAL Thanks for confirming, I have assigned the issue to you. Please make a PR when you are done.

If needed I can also update the XML to be compatible with compossable retaining the XML addons.

Is it required somewhere? Do if it is necessary for now, we will remove them once we migrate all the things in jetpack.

[SOUMEN-PAL]

Hello @MohitMaliFtechiz
The migration of HelpFragment is about to be completed and here is an update about how it going on.
The code is entirely written in jetpack Compose as required.
(A little bit of enhancement are left and will soon be sending a PR in upcoming days after completing.)

Task.mp4

I just have a question about the linter which is needed during commit, do I need to manually adhere to all the things or is there any automatic solution.

[MohitMaliFtechiz]

@SOUMEN-PAL Thanks for the update.

I just have a question about the linter which is needed during commit, do I need to manually adhere to all the things or is there any automatic solution.

You have to fix those lint issues. There are some automatic solutions, like formatting and removing unused imports. But apart from this, you have to manually fix other lint problems.

[SOUMEN-PAL]

@MohitMaliFtechiz The Migration is done completely here is the video below. I am having problem with rules in Lint as compossable functions has a naming convention starting with capital Letters and the rules in lint says it has to be small.
When i force the compossable names to be in ( camelCase ) the initial rules are successes but due to improper Name of compossable lint gives a new warning.
I am not seeing any way to send a Commit and request a pull request.

(commit with --no-verify is possible but i need permission should I do that?)

MigrationHelp.mp4

and here is the example of the kind of Lint Errors I am getting:-

FunctionNaming - [Function names should match the pattern: ^([a-z$][a-zA-Z$0-9])|(.*)$] at /home/soumen/Documents/kiwix-android/core/src/main/java/org/kiwix/kiwixmobile/core/help/HelpItem.kt:70:5
FunctionNaming - [Function names should match the pattern: ^([a-z$][a-zA-Z$0-9])|(.*)$] at /home/soumen/Documents/kiwix-android/core/src/main/java/org/kiwix/kiwixmobile/core/help/HelpItem.kt:124:5
FunctionNaming - [Function names should match the pattern: ^([a-z$][a-zA-Z$0-9])|(.*)$] at /home/soumen/Documents/kiwix-android/core/src/main/java/org/kiwix/kiwixmobile/core/help/HelpScreen.kt:68:5
FunctionNaming - [Function names should match the pattern: ^([a-z$][a-zA-Z$0-9])|(.*)$] at /home/soumen/Documents/kiwix-android/core/src/main/java/org/kiwix/kiwixmobile/core/help/HelpScreen.kt:95:13
FunctionNaming - [Function names should match the pattern: ^([a-z$][a-zA-Z$0-9])|(.*)$] at /home/soumen/Documents/kiwix-android/core/src/main/java/org/kiwix/kiwixmobile/core/help/HelpScreen.kt:120:13
FunctionNaming - [Function names should match the pattern: ^([a-z$][a-zA-Z$0-9])|(.*)$] at /home/soumen/Documents/kiwix-android/core/src/main/java/org/kiwix/kiwixmobile/core/help/HelpScreen.kt:145:13

[MohitMaliFtechiz]

@SOUMEN-PAL These are the detekt issue since the project is now starting supporting the compose so the detekt rules were not configured according to compose. Here is the doc of detekt https://detekt.dev/docs/introduction/compose/ how we can configure rules of detekt for compose.

[jackq97]

@SOUMEN-PAL These are the detekt issue since the project is now starting supporting the compose so the detekt rules were not configured according to compose. Here is the doc of detekt https://detekt.dev/docs/introduction/compose/ how we can configure rules of detekt for compose.

@MohitMaliFtechiz We will need to update the detekt configuration file to support composable functions , by changing rules for functions to support naming conventions for composable functions and ignoring annotation for Composable. There are other parameters as well. i can do that to add support for jetpack compose.

[jackq97]

@MohitMaliFtechiz I've made the changes and made a pr you can check it.