Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/usr/bin/patch fails patching a file, cannot change group of temporary file #16

Open
brownmarkliam opened this issue Jul 2, 2024 · 1 comment
Open

/usr/bin/patch fails patching a file, cannot change group of temporary file #16

brownmarkliam opened this issue Jul 2, 2024 · 1 comment

Comments

@brownmarkliam
Copy link

/usr/bin/patch does not work on the NFS41 filesystem. patch -p1 creates a temporary file, applies the patch, but then fails to set the group owner of the original file to the new, patched file, and then bails out with an error.
@brownmarkliam
Copy link
Author

Versions:
Cygwin: 3.5.3
ms-nfs41-client: 20240528_12h15m_git0cb4428
Windows: 10

kofemann pushed a commit that referenced this issue Jul 5, 2024
@gisburn @kofemann
cygwin: Implement Unix_User+<uid> and Unix_Group+<gid> support in |ma…
3dae332 
…p_nfs4ace_who()|

/usr/bin/patch failed patching a file, complaining that it cannot
change the group of it's temporary file.
This happened because Cygwin is generating Unix_Group+<gid> SIDs
based on the Nfs3Attr EA |gid|, instead of taking the native SID
returned by Windows.
And some tools like patch(1) end-up just copying that SID, which
our |map_nfs4ace_who()| did not support.

Implementing Unix_User+<uid> and Unix_Group+<gid> support in
|map_nfs4ace_who()| fixes this.

See #16

Fixes: Issue #16
Reported-by: Mark Liam Brown <brownmarkliam@gmail.com>
Signed-off-by: Cedric Blancher <cedric.blancher@gmail.com>
Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brownmarkliam