Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add husky to the project #534

Open
Ameerjafar opened this issue Jun 10, 2024 · 7 comments
Open

Add husky to the project #534

Ameerjafar opened this issue Jun 10, 2024 · 7 comments

Comments

@Ameerjafar
Copy link

Description

currently in our project we don't have husky if we use husky we can easily formatting the code if before the make the commit by using pre commit

Screenshots

No response

Additional information

No response

@Ameerjafar
Copy link
Author

@undera can you please assign me this issue i really wanted to work on this enhancement man.

@undera
Copy link
Collaborator

undera commented Jun 10, 2024

@Ameerjafar I'm not sure what this issue is about. Does the project have issues with code formatting? None that I know of. Can you give examples?

Generally, feel free to bring PR with the changes you propose, no need for formal assignments.

@Ameerjafar
Copy link
Author

Ameerjafar commented Jun 10, 2024

it the contributor changed something in the codebase but if he/she did not formatting the code properly if we use husky, before the commit the code automatically formatted sir. @undera

@undera
Copy link
Collaborator

undera commented Jun 10, 2024

Bring the PR, we'll see what happens. Not all the automatic formatting that is good.

@Ameerjafar
Copy link
Author

just the changed file only formatting sir before the commit @undera

@undera
Copy link
Collaborator

undera commented Jun 10, 2024

I understand that. So where's the PR with proposed changes?

@Ameerjafar
Copy link
Author

I understand that. So where's the PR with proposed changes?

done sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants