-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Probably bugs #992
Comments
Sure. I forgot to remove this branch when I was getting rid of long emulation. Now in all modern browser Can you please create a PR so that I could mention you in release notes to next release?
Yes, you are right. But the even more major issue here is that DCE does not remove methods, but rather makes them abstract. Previously it was actually removing all unused methods, but then I changed this due to some bugs. Perhaps, I'll revisit this and try to find other fixes for these issues, because current approach seems confusing and error prone. However, I'm not sure about your solution, I need to review it better, when I have free time. |
Moreover, next condition, |
Are you OK to drop support for older browsers? Some people I know still use older iphones which are not updated anymore. |
Looks like the latest device that does not support at least Safari 13, is iPhone 6, which was released more that 10 years ago. I hardly imagine that any major web app (like youtube) supports such ancient iPhone. |
numeric.js
return new Long($rt_numberConversionView.getInt32(0, true), $rt_numberConversionView.getInt32(4, true));
There is no identifier 'Long'
ClassReaderSourceHelper.java resolveMethodImplementation
In addition to 'ordinary' abstract methods, there are methods that were made abstract by dead code elimination. In this case, searching for overridden method in superclass might find non-abstract candidate. Specific problem is
teavm_javaConstructorExists("java.lang.ClassCastException", "()V")
returning true even if this constructor is not used and not even emitted. My solution (might be incorrect, not sure how to do better):The text was updated successfully, but these errors were encountered: