Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project folder - project file naming mismatch #304

Closed
petrsvihlik opened this issue Nov 26, 2021 · 10 comments
Closed

Project folder - project file naming mismatch #304

petrsvihlik opened this issue Nov 26, 2021 · 10 comments
Assignees
Milestone

Comments

@petrsvihlik
Copy link
Contributor

image

@Simply007
Copy link
Contributor

This issue was fixed in #300.

The folders are already unified in https://github.com/Kentico/kontent-delivery-sdk-net/tree/vNext

@petrsvihlik
Copy link
Contributor Author

petrsvihlik commented Nov 26, 2021

oh, I see.
any reason to call it Kentico.Kontent.Delivery.Urls and not just Kentico.Kontent.Urls?
-> there was an idea to have a generic and very lightweight "Urls" package that would sit on top of Kentico.Kontent.Abstractions and packages like Kontent.Statiq would not have to be dependent on the whole Kentico.Kontent.Delivery package. this package would later on contain all URL handling related to Kentico Kontent (including MAPI) and edit links.

@petrsvihlik
Copy link
Contributor Author

not to mention the breaking change :)
image

@Simply007
Copy link
Contributor

oh, I see. any reason to call it Kentico.Kontent.Delivery.Urls and not just Kentico.Kontent.Urls? -> there was an idea to have a generic and very lightweight "Urls" package that would sit on top of Kentico.Kontent.Abstractions and packages like Kontent.Statiq would not have to be dependent on the whole Kentico.Kontent.Delivery package. this package would later on contain all URL handling related to Kentico Kontent (including MAPI) and edit links.

Yeap, but then there is a section https://github.com/Kentico/kontent-delivery-sdk-net/tree/vNext/Kentico.Kontent.Delivery.Urls/QueryParameters that is tied to Delivery API.

It might be possible to split the query parameters and DeliveryEndpointUrlBuilder into Kentico.Kontent.Delivery.Urls and keep the ImageTransfromation in Kentico.Kontent.Urls package. What do you think?

@petrsvihlik
Copy link
Contributor Author

There are two ways to do it:

have 1 package with:

  • Kentico.Kontent.Urls
    • Kentico.Kontent.Urls.Delivery
    • Kentico.Kontent.Urls.Management
    • Kentico.Kontent.Urls.ImageTransformation

or have 3 packages:

  • Kentico.Kontent.Delivery.Urls
  • Kentico.Kontent.Management.Urls
  • Kentico.Kontent.ImageTransformation.Urls

@Simply007
Copy link
Contributor

OK, I will keep this issue open and we will decide, how to deal with it. My current preference is:

Kentico.Kontent.Delivery.Urls
Kentico.Kontent.Management.Urls -> this could be done as a part of #249
Kentico.Kontent.ImageTransformation.Urls

But let's keep the final decision for maintainers sync.

@Simply007 Simply007 reopened this Nov 26, 2021
@Simply007 Simply007 added this to the v16 milestone Dec 2, 2021
@Simply007
Copy link
Contributor

We will decide about final namespaces on Thu 2021-12-09 (now I am more in favor of Kentico.Kontent.Urls 👼🏼).

@Simply007
Copy link
Contributor

Simply007 commented Dec 9, 2021

We have decided for this approach:

Kentico.Kontent.Urls (one package with namespaces)

  • Kentico.Kontent.Urls.Delivery
  • Kentico.Kontent.Urls.Management
  • Kentico.Kontent.Urls.ImageTransformation

@Simply007 Simply007 self-assigned this Dec 9, 2021
@petrsvihlik
Copy link
Contributor Author

lovely

@Simply007
Copy link
Contributor

Simply007 commented Dec 10, 2021

Fixed in #310

I am going to release another beta and notify about it in #305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants