Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant padding method in models? #13

Open
UrosOgrizovic opened this issue Jan 14, 2021 · 0 comments
Open

Redundant padding method in models? #13

UrosOgrizovic opened this issue Jan 14, 2021 · 0 comments

Comments

@UrosOgrizovic
Copy link

Why the need for both pad(self, s, max_length) and pad_document(self, d, max_document_length) in from_presentation.py, max_sentence_embedding.py and single_lstm.py? To me, it seems that those two methods perform the same task - they just have different variable names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@UrosOgrizovic