From 1f063632b87ed997101feceb06c7837d61be0e5f Mon Sep 17 00:00:00 2001 From: "Kevin P. Fleming" Date: Sun, 13 Oct 2024 09:07:16 -0400 Subject: [PATCH] Remove support for Python 3.8. Prepare for version 24.2.0 release. --- .pre-commit-config.yaml | 2 +- CHANGELOG.md | 4 ++++ README.md | 2 +- pyproject.toml | 33 +++++++++++++++---------------- src/plugins/modules/tsigkey.py | 2 +- src/plugins/modules/zone.py | 2 +- tox.ini | 2 +- workflow-support/make_ci_image.sh | 2 +- workflow-support/versions.json | 2 +- 9 files changed, 27 insertions(+), 24 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 33afebc..e0f94c6 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -2,6 +2,6 @@ --- repos: - repo: https://github.com/tox-dev/pyproject-fmt - rev: "2.2.1" + rev: "2.3.0" hooks: - id: pyproject-fmt diff --git a/CHANGELOG.md b/CHANGELOG.md index 5e29637..7f5b9f1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,8 @@ for emergencies). ## [Unreleased] +## [24.2.0] - 2024-10-13 + ### Changed - Added testing against PowerDNS Authoritative Server 4.9.x. @@ -24,6 +26,8 @@ for emergencies). - Added testing against Python 3.13 (beta). +- Removed support for Python 3.8. + ## [24.1.0] - 2024-02-09 ### Changed diff --git a/README.md b/README.md index 6cfc434..7b0e8ff 100644 --- a/README.md +++ b/README.md @@ -2,7 +2,7 @@ Open Source Initiative Approved License logo [![CI](https://github.com/kpfleming/ansible-powerdns-auth/workflows/CI/badge.svg)](https://github.com/kpfleming/ansible-powerdns-auth/actions?query=workflow%3ACI) -[![Python](https://img.shields.io/badge/python-3.8+-blue.svg)](https://www.python.org/downloads/release/python-3812/) +[![Python](https://img.shields.io/badge/python-3.9+-blue.svg)](https://www.python.org/downloads/release/python-3920/) [![License - Apache 2.0](https://img.shields.io/badge/License-Apache%202.0-9400d3.svg)](https://spdx.org/licenses/Apache-2.0.html) [![Code Style and Quality - Ruff](https://img.shields.io/badge/Code%20Quality-Ruff-red.svg)](https://github.com/astral-sh/ruff) diff --git a/pyproject.toml b/pyproject.toml index a443942..93d1892 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,21 +1,20 @@ [tool.ruff] -src = ["src"] -target-version = "py38" +target-version = "py39" line-length = 100 -[tool.ruff.lint] -select = ["ALL"] -ignore = [ - "ANN", # Mypy is better at this. - "COM812", # conflicts with formatter - "C901", # Leave complexity to me. - "D", # We have different ideas about docstrings. - "INP001", # we don't care that these are in implicit namespace packages - "ISC001", # conflicts with formatter - "PLR0912", # Leave complexity to me. - "PLR0915", # Leave complexity to me. - "RUF012", # no need for this warning in Ansible modules - "S101", # assert - "TRY301", # Raise in try blocks can totally make sense. +src = [ "src" ] +lint.select = [ "ALL" ] +lint.ignore = [ + "ANN", # Mypy is better at this. + "C901", # Leave complexity to me. + "COM812", # conflicts with formatter + "D", # We have different ideas about docstrings. + "INP001", # we don't care that these are in implicit namespace packages + "ISC001", # conflicts with formatter + "PLR0912", # Leave complexity to me. + "PLR0915", # Leave complexity to me. + "RUF012", # no need for this warning in Ansible modules + "S101", # assert + "TRY301", # Raise in try blocks can totally make sense. ] -unfixable = ["F401"] +lint.unfixable = [ "F401" ] diff --git a/src/plugins/modules/tsigkey.py b/src/plugins/modules/tsigkey.py index 677290c..6d03d32 100755 --- a/src/plugins/modules/tsigkey.py +++ b/src/plugins/modules/tsigkey.py @@ -11,7 +11,7 @@ api_exception_handler, ) -assert sys.version_info >= (3, 8), "This module requires Python 3.8 or newer." +assert sys.version_info >= (3, 9), "This module requires Python 3.9 or newer." DOCUMENTATION = """ %YAML 1.2 diff --git a/src/plugins/modules/zone.py b/src/plugins/modules/zone.py index d9878d9..1292f1d 100755 --- a/src/plugins/modules/zone.py +++ b/src/plugins/modules/zone.py @@ -11,7 +11,7 @@ api_exception_handler, ) -assert sys.version_info >= (3, 8), "This module requires Python 3.8 or newer." +assert sys.version_info >= (3, 9), "This module requires Python 3.9 or newer." DOCUMENTATION = """ %YAML 1.2 diff --git a/tox.ini b/tox.ini index c050c36..4290f09 100644 --- a/tox.ini +++ b/tox.ini @@ -63,7 +63,7 @@ commands= ruff check --output-format=full --fix --show-fixes src ansible-lint --fix all --strict --profile production -v -[testenv:py{38,39,310,311,312,313}-ci-action] +[testenv:py{39,310,311,312,313}-ci-action] deps= {[galaxy-setup]deps} ansible-core diff --git a/workflow-support/make_ci_image.sh b/workflow-support/make_ci_image.sh index eb31005..56ea1ee 100755 --- a/workflow-support/make_ci_image.sh +++ b/workflow-support/make_ci_image.sh @@ -17,7 +17,7 @@ pdns_run=(libsqlite3-0 libluajit-5.1-2) lint_deps=(shellcheck) toxenvs=(lint-action ci-action publish-action) -cimatrix=(py3{8,9,10,11,12,13}) +cimatrix=(py3{9,10,11,12,13}) c=$(buildah from "${base_image}") diff --git a/workflow-support/versions.json b/workflow-support/versions.json index 55f68cb..7e361e9 100644 --- a/workflow-support/versions.json +++ b/workflow-support/versions.json @@ -1 +1 @@ -versions={"pdns":["4.7", "4.8", "4.9", "master"], "python": ["py38", "py39", "py310", "py311", "py312", "py313"]} +versions={"pdns":["4.7", "4.8", "4.9", "master"], "python": ["py39", "py310", "py311", "py312", "py313"]}