Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all implementations (at least the keyed ones) #1789

Open
krausest opened this issue Dec 12, 2024 · 3 comments
Open

Update all implementations (at least the keyed ones) #1789

krausest opened this issue Dec 12, 2024 · 3 comments

Comments

@krausest
Copy link
Owner

I'll try to update the implementations (starting with keyed, I've not yet decided if non-keyed are worth it) if there's a newer minor or major version (I'll skip patch versions)

Implementations that fail to build or run will be moved to broken-frameworks and the last committer will be asked to fix the implementation.

@krausest
Copy link
Owner Author

It's really annoying to do this by hand.
I changed the cli to support a command for automating the task:
node cli.js update-frameworks --type keyed &> log.txt
The script iterates over all frameworks, checks if there's a newer major or minor version for. a package specified in the js-framework-benchmark.frameworkVersionFromPackage property in the package.json (patch versions are ignored).
If a newer version is found we'll do a ncu -u and rebuild and check the implementation.
If that fails the implementation is restored via `git restore .``

What's currently missing (maybe I'l add that later):

  • Automatically moving broken builds to the broken-frameworks folder
  • Building broken builds after restoring (necessary if they are not moved. The build remains broken otherwise)
  • Automatically creating and assigning an issue :)

@krausest
Copy link
Owner Author

Here's the log (yeah with a spelling error...):

Sucessfully updated frameworks/keyed/alpine
Sucessfully updated frameworks/keyed/apprun
Retire keyed/art - js-art is older than a year
Retire keyed/dojo - @dojo/framework is older than a year
Retire keyed/ef-js - ef-core is older than a year
Failed to update frameworks/keyed/ember
Sucessfully updated frameworks/keyed/fntags
Failed to update frameworks/keyed/fre
Sucessfully updated frameworks/keyed/hono
Retire keyed/hyperapp - hyperapp is older than a year
Retire keyed/incremental-dom - incremental-dom is older than a year
Failed to update frameworks/keyed/ivi
Sucessfully updated frameworks/keyed/karyon
Retire keyed/knockout - knockout is older than a year
Failed to update frameworks/keyed/ko-jsx
Failed to update frameworks/keyed/legend-state
Sucessfully updated frameworks/keyed/lwc
Retire keyed/marionette - marionette is older than a year
Retire keyed/marionette-backbone - marionette is older than a year
Failed to update frameworks/keyed/marko
Failed to update frameworks/keyed/maverick
Error checking keyed/mikado-proxy
Failed to update frameworks/keyed/million
Failed to update frameworks/keyed/mobx-jsx
Sucessfully updated frameworks/keyed/owl
Sucessfully updated frameworks/keyed/preact-classes
Sucessfully updated frameworks/keyed/preact-hooks
Sucessfully updated frameworks/keyed/preact-signals
Failed to update frameworks/keyed/qwik
Sucessfully updated frameworks/keyed/ractive
Failed to update frameworks/keyed/react-jotai
Failed to update frameworks/keyed/react-kr-observable
Sucessfully updated frameworks/keyed/react-mobX
Sucessfully updated frameworks/keyed/react-redux-rematch
Retire keyed/react-rxjs - react:@react-rxjs/core is older than a year
Failed to update frameworks/keyed/react-starbeam
Failed to update frameworks/keyed/react-tracked
Sucessfully updated frameworks/keyed/reflex-js
Failed to update frameworks/keyed/reflex-js-atomic
Failed to update frameworks/keyed/rescript-react
Sucessfully updated frameworks/keyed/riot
Retire keyed/s2 - s2-engine is older than a year
Failed to update frameworks/keyed/san-composition
Sucessfully updated frameworks/keyed/san-store
Retire keyed/sinuous - sinuous is older than a year
Failed to update frameworks/keyed/skruv
Sucessfully updated frameworks/keyed/spheres
Sucessfully updated frameworks/keyed/stencil
Sucessfully updated frameworks/keyed/svelte
Sucessfully updated frameworks/keyed/svelte-classic
Retire keyed/udomsay-esx - udomsay is older than a year
Retire keyed/udomsay-tpl - udomsay is older than a year
Sucessfully updated frameworks/keyed/uhtml
Failed to update frameworks/keyed/ui5-webcomponents
Failed to update frameworks/keyed/valtio
Sucessfully updated frameworks/keyed/vanjs
Sucessfully updated frameworks/keyed/viewfly
Failed to update frameworks/keyed/voby
Sucessfully updated frameworks/keyed/vue-jsx
Error checking keyed/vue-jsx-vapor
Sucessfully updated frameworks/keyed/vue-pinia
Error checking keyed/vue-vapor
Retire keyed/vuerx-jsx - vuerx-jsx is older than a year

The following frameworks must be checked manually
keyed/anansi has no frameworkVersionFromPackage
keyed/arrowjs has no frameworkVersionFromPackage
keyed/blazor-wasm has no frameworkVersionFromPackage
keyed/blazor-wasm-aot has no frameworkVersionFromPackage
keyed/dioxus has no frameworkVersionFromPackage
keyed/dominator has no frameworkVersionFromPackage
keyed/doohtml has no frameworkVersionFromPackage
keyed/doohtml-dom has no frameworkVersionFromPackage
keyed/goui has no frameworkVersionFromPackage
keyed/helix has no frameworkVersionFromPackage
keyed/laminar has no frameworkVersionFromPackage
keyed/leptos has no frameworkVersionFromPackage
keyed/lui has no frameworkVersionFromPackage
keyed/miso has no frameworkVersionFromPackage
keyed/misojs has no frameworkVersionFromPackage
keyed/mogwai has no frameworkVersionFromPackage
keyed/openui5 has no frameworkVersionFromPackage
keyed/quel has no frameworkVersionFromPackage
keyed/re-frame has no frameworkVersionFromPackage
keyed/reagent has no frameworkVersionFromPackage
keyed/sauron has no frameworkVersionFromPackage
keyed/silkenweb has no frameworkVersionFromPackage
keyed/spair has no frameworkVersionFromPackage
keyed/spair-qr has no frameworkVersionFromPackage
keyed/stdweb has no frameworkVersionFromPackage
keyed/sycamore has no frameworkVersionFromPackage
keyed/vanillajs has no frameworkVersionFromPackage
keyed/vanillajs-3 has no frameworkVersionFromPackage
keyed/vanillajs-lite has no frameworkVersionFromPackage
keyed/vanillajs-wc has no frameworkVersionFromPackage
keyed/wasm-bindgen has no frameworkVersionFromPackage
keyed/yew has no frameworkVersionFromPackage
keyed/yew-hooks has no frameworkVersionFromPackage

@krausest
Copy link
Owner Author

I'll move all frameworks that don't survive the ncu -u to the broken-frameworks folder after trying to apply simple fixes.
There's no point in running the benchmark on new chrome versions for outdated framework versions. I'll create an issue for all broken builds (manually 😄 )

The retirement is currently only a recommendation. I retire frameworks if the really look dead and outdated (and aren't in widespread use).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant