dotnet8 support

[haraldsteinlechner]

in my new dotnet8 branch it generally seems to work, i'm need some testing still.

I found that @jskripsky had a take on dotnet 8 as well. What was your status?

issues i found on the way

• shall we remove the dotnet7 target since it does not work in dotnet8 envs and dotnet7 is out of support
• is caching in design mode working as intended
• is it ok that the ilmerge step uses netstandard build of adaptivy.msbuild.dotnet?
• System.Diagnostics.DiagnosticSource is missing from the dependencies
  . This seems to be a transitive dependency of the compiler services. After switching to nuget this might have been lost? Are there any other transitive deps missing?

[jskripsky]

To be honest, the changes on my branch were nothing more than a quick and dirty hack to make Adaptify work on .NET 8 and Linux as a dotnet tool.

The only detail that might be of interest is a unrelated bug in Runner.fs. I think the line should read

let dir = Path.Combine(outputPath, hash)

instead of

let dir = Path.Combine(Path.GetTempPath(), hash)

I'll happily test @haraldsteinlechner's dotnet 8 branch on Linux in the course of the next few days.

[haraldsteinlechner]

Hi, thanks for answering and bringing up this line. Actually i noticed it when looking at the caching mechanism which seems to be broken (point 2 in my list above). In my rather huge testing project adaptify seems runs forever because of this.
I remember problems with the cache files a while back. @krauthaufen if you have memories why this line is this way, please give me some pointers. I will investigate it further tomorrow (i already created test nuget packages i need to test myself first)

[haraldsteinlechner]

hi @jskripsky
we took a quite different approach. instead of having a dotnet project which calls adaptify we call the command line tool now directly from within a msbuild targets file. we already created new version here: https://www.nuget.org/packages/adaptify/1.3.2
usage is via adaptify.msbuild, which requires the adaptify tool to be installed (best using a local dotnet tool install)
the code is currently still in this branch: https://github.com/krauthaufen/Adaptify/tree/dotnet8
i'm just testing this one in a huge project... hope this helps us getting rid of those problems altogether...

cheers,
harald