Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ObservedGeneration in the Custom Resource Definition (CRD) #179

Open
karthik507 opened this issue Jan 15, 2025 · 0 comments
Open

Comments

@karthik507
Copy link

We are currently facing challenges in assessing changes made to the spec of the Notebook CRD due to the absence of the ObservedGeneration field in its status. Adding this field would enable us to determine if the operator has acted on updates to the CR spec, making it easier to track the transition of the Notebook resource from state "x" to state "y."

Environment :

  1. Notebook ( Notebooks 1.0) version -> v1.9.2
  2. jupyter-web-app version -> v1.9.2

Current Status :

status:
  conditions:
  - lastProbeTime: "2025-01-15T13:42:07Z"
    lastTransitionTime: "2025-01-15T13:41:57Z"
    status: "True"
    type: Initialized
  - lastProbeTime: "2025-01-15T13:42:07Z"
    lastTransitionTime: "2025-01-15T13:42:07Z"
    status: "True"
    type: Ready
  - lastProbeTime: "2025-01-15T13:42:07Z"
    lastTransitionTime: "2025-01-15T13:42:07Z"
    status: "True"
    type: ContainersReady
  - lastProbeTime: "2025-01-15T13:42:07Z"
    lastTransitionTime: "2025-01-15T13:41:57Z"
    status: "True"
    type: PodScheduled
  containerState:
    running:
      startedAt: "2025-01-15T13:42:06Z"
  readyReplicas: 1

Expected Status :

status:
**observedGeneration: 1**
  conditions:
  - lastProbeTime: "2025-01-15T13:42:07Z"
    lastTransitionTime: "2025-01-15T13:41:57Z"
    status: "True"
    type: Initialized
  - lastProbeTime: "2025-01-15T13:42:07Z"
    lastTransitionTime: "2025-01-15T13:42:07Z"
    status: "True"
    type: Ready
  - lastProbeTime: "2025-01-15T13:42:07Z"
    lastTransitionTime: "2025-01-15T13:42:07Z"
    status: "True"
    type: ContainersReady
  - lastProbeTime: "2025-01-15T13:42:07Z"
    lastTransitionTime: "2025-01-15T13:41:57Z"
    status: "True"
    type: PodScheduled
  containerState:
    running:
      startedAt: "2025-01-15T13:42:06Z"
  readyReplicas: 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Triage
Development

No branches or pull requests

1 participant