Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cp version to dataplaneInsight #12481

Open
johncowen opened this issue Jan 8, 2025 · 0 comments
Open

add cp version to dataplaneInsight #12481

johncowen opened this issue Jan 8, 2025 · 0 comments
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@johncowen
Copy link
Contributor

johncowen commented Jan 8, 2025

Description

In the GUI we've wondered about being able to inform users when certain DPPs are not using the same version of Kuma as the Zone they are in.

We already have several related properties in certain HTTP endpoints (kumaCPCompatible, and version of the DPP), we could also use the version of the CP where the GUI is running to make a check, but this is not really the check we want to do seeing as ideally we want "Is this DPP on the same version of Kuma as the Zone it is in?"

Let me know if you need more info, or anyone feel free to add info here if it helps.

The way to do this would be to add this info inside the dataplane insight.

It should most likely be set here:

if metadata.GetVersion().GetDependencies() != nil {
metadata.Version.Dependencies[dependencyName] = val.GetStringValue()
}
} else {
dynamicMetadata[field] = val.GetStringValue()
}
}
metadata.DynamicMetadata = dynamicMetadata

@johncowen johncowen added kind/feature New feature triage/pending This issue will be looked at on the next triage meeting labels Jan 8, 2025
@lahabana lahabana changed the title add HTTP API to understand version mismatches between DPP and ZoneCP add cp version to dataplaneInsight Jan 8, 2025
@bartsmykla bartsmykla added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

2 participants