Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any dark mode for this app? #5

Open
FraH90 opened this issue Aug 15, 2021 · 7 comments
Open

Is there any dark mode for this app? #5

FraH90 opened this issue Aug 15, 2021 · 7 comments

Comments

@FraH90
Copy link

FraH90 commented Aug 15, 2021

Hi, first of all this app is the BEST epub reader that I've found for windows.
However, I feel the lack of two functionalities that I still haven't found in this app:

  • the dark mode, to read ebooks in inverted colors (black background, white text)
  • the possibility to highlight text in the books (obviusly storing them on the epub, after the file is closed)

I would love very very much if those functionalities would be added!

@kurema
Copy link
Owner

kurema commented Aug 16, 2021

Thanks for you suggestion. It sounds to me nice idea to support dark theme for epub viewer.
But we have two problem.

  • UWP WebView which is based on edgeHTML doesn't seem to support prefers-color-scheme.
  • Bibi (the engine of epub reader) does not support dark theme yet (issue).

We plan to move to WinUI 3 / WebView2 (based on Chromium). It will fix the first problem. But it should take some time (maybe in 2022 / WinUI 3 roadmap).
About Bibi, it can be difficult. Epub files have its own css and they don't support dark theme in most cases. It is easy to add

@media (prefers-color-scheme: dark) { :root{filter: invert(100%) hue-rotate(180deg);}  }

somewhere but I think it causes numerous problems. Such as

  • It does not work correctly if css of the epub file already support dark theme.
  • Image can be strange.

In conclusion, we really think it's lovely idea but it should take a time to implement.

@kurema
Copy link
Owner

kurema commented Aug 16, 2021

I noticed some other small issue for the dark theme. They will be fixed in next release.
image
image

@FraH90
Copy link
Author

FraH90 commented Aug 19, 2021

Thanks for you suggestion. It sounds to me nice idea to support dark theme for epub viewer.
But we have two problem.

  • UWP WebView which is based on edgeHTML doesn't seem to support prefers-color-scheme.
  • Bibi (the engine of epub reader) does not support dark theme yet (issue).

We plan to move to WinUI 3 / WebView2 (based on Chromium). It will fix the first problem. But it should take some time (maybe in 2022 / WinUI 3 roadmap).
About Bibi, it can be difficult. Epub files have its own css and they don't support dark theme in most cases. It is easy to add

@media (prefers-color-scheme: dark) { :root{filter: invert(100%) hue-rotate(180deg);}  }

somewhere but I think it causes numerous problems. Such as

  • It does not work correctly if css of the epub file already support dark theme.
  • Image can be strange.

In conclusion, we really think it's lovely idea but it should take a time to implement.

I perfectly get it.. so it's just matter of time, that you move the platform to WebView2 and wait for bibi to implement the dark mode.

And what about the other functionality I mentioned? The possibility to highlights some passages in the epub books?

@kurema
Copy link
Owner

kurema commented Aug 20, 2021

Sorry, I forgot to mention that. About highlighting, I think it's also an issue of Bibi. I don't think I can do anything to implement (other than creating a pull request. which I won't).
There is an issue on Bibi, but it's unlikely.

@kurema
Copy link
Owner

kurema commented Aug 27, 2021

v3.2.2.0 have the experimental dark mode feature.
If you turn on the dark mode for Windows and the option below, you can use dark mode in Epub as default.
image
You can also manually turn on/off.

  1. Click here.
    image
  2. Here, here and here.
    image
  3. Result
    image

I just invoked a small script. This isn't the perfect solution, but it's here for now.

if(document.body.style.background===""){document.body.style.background='white';}
document.body.style.filter='invert(100%) hue-rotate(180deg)';

@kurema
Copy link
Owner

kurema commented Aug 27, 2021

If you really need the highlight feature, updated Epub.js Reader seems to have it. You can change the Epub engine in the setting.
image
image

@FraH90
Copy link
Author

FraH90 commented Aug 27, 2021

Thank you very much!
I'll try those features as soon as I'll install v3.2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants