Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in filename #30

Closed
cboulay opened this issue Jun 30, 2020 · 2 comments · Fixed by #37
Closed

Bug in filename #30

cboulay opened this issue Jun 30, 2020 · 2 comments · Fixed by #37

Comments

@cboulay
Copy link
Contributor

cboulay commented Jun 30, 2020

From a user in Slack:

I would like to set up the Labrecorder to store recordings to C:\Recordings\exp_%p_%b.xdf (running Windows 10 OS)
When i set the storageLocation in the config File to:
StorageLocation="C:\Recordings\exp_%p_%b.xdf"
the result is that LabRecorder simply ignores the Recordings Subfolder and saves the File directly to C:
The only way to get it to save to the correct Folder is to add a (nonexistent) subfolder to the Storage Location:
StorageLocation="C:\Recordings\xyz\exp_%p_%b.xdf"
Now it again ignores the last subfolder before the FIleName and saves to the intended Location.
I don't think this is the intended behaviour. Am i doing something wrong?

I haven't investigated yet, but it's either in parsing the storage location somewhere around here or buildFilename or when starting recording here.

@cboulay cboulay changed the title Bug in Bug in filename Jun 30, 2020
@cboulay
Copy link
Contributor Author

cboulay commented Aug 12, 2020

Same as #18

@cboulay
Copy link
Contributor Author

cboulay commented Aug 14, 2020

The bug was that the StorageLocation path-part first went through a Path() op then another AbsolutePath()... and (I think) each one trims off the end and gives the parent. So this resulted in parent-of-parent. In the fix, the first Path() was removed and only one call to AbsolutePath() is kept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant