Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect reference to info-object #15

Open
jonashogstrom opened this issue May 18, 2021 · 2 comments
Open

Incorrect reference to info-object #15

jonashogstrom opened this issue May 18, 2021 · 2 comments

Comments

@jonashogstrom
Copy link

for (int k = 0; k < info.channel_count(); k++)

It seems as the linked line should reference the local variable "inf" and not "info". I suggest splitting the inspection of the stream info into a separate method to make it clear that the two sections of code is independent.

@dmedine
Copy link
Contributor

dmedine commented May 19, 2021

Or rename inf to inletInfo to distinguish it from info which is the StreamInfo object used to create the outlet. The have identical information on the insides, of course. I would prefer this to adding a separate method as the example programs obey a kind of template that is standard across all the different language wrappers.

@jonashogstrom
Copy link
Author

Renaming the variable to make it easier to tell then apart makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants