Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affirmation.bas review comments #1

Open
Retrophile opened this issue Nov 12, 2024 · 0 comments
Open

Affirmation.bas review comments #1

Retrophile opened this issue Nov 12, 2024 · 0 comments

Comments

@Retrophile
Copy link

Line 15 - A nice use of C% but since it runs before C% is defined and since C% is 0 by default, the colours used on a freshly reset machine are black on black. Took me ages to work out what was happening because I kept thinking the emulator had crashed and so I reloaded it which rest C% back to 0 again. Ignoring the problem with similar colours (a 16 colour mode will suffer less) you still need to ensure that the two random values are not the same or you could end up printing text in the same colour as the background.

Lines 25-27 a nice use of system variables : They need to come after the mode definition but before you use them.

Line 30 Has an extra S in POSITIVE. (so -33 should become -32)

Lines 130,190, 240, 290
As suspected these are all 40 characters or over. Fixable in line 800?

Line 240 is missing an A after I AM

Line 800 If you want to keep the existing affirmation string lengths, depending on the chosen mode, you will have to split them over two lines remembering to break them at a space.
e.g. Try to keep the strings of a similar length, try breaking at the first space after string length/2.

How about using MODE 7 instead of one of the others? Not as many colours but you can use double height etc :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant