Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow aligning on commidity char instead of decimal separator #106

Closed
entropitor opened this issue May 24, 2020 · 2 comments · Fixed by #135
Closed

Allow aligning on commidity char instead of decimal separator #106

entropitor opened this issue May 24, 2020 · 2 comments · Fixed by #135

Comments

@entropitor
Copy link
Contributor

I love this plugin. Unfortunately, it aligns on decimal separator while I'd prefer to align on the commodity symbol. It'd be nice if this plugin has support for that

@alerque
Copy link
Member

alerque commented May 25, 2020

I'd love to accept a PR that accomplished that as an option! I don't have time to make it happen right now I'd be willing to help review and tweak and contributions that come up for merging.

I don't personally like the alignment either — but my beef is that I have multiple different localized currencies in my ledgers ($1,000.00, ₺1.000,00, 1 000,00 ₸, etc.) and the plugin cannot currently handle more than one decimal separator for alignment. Hence it aligns all my USD transactions at the thousands place and TRY transactions at the decimal.

I imagine a similar problem will come up aligning on commodities any time more than one is used in a ledger.

By the way my workaround is to do alignment via hledger print, but that's less than ideal for a number of reasons. It would be great to come up with a more robust alignment system for this plugin.

@alerque
Copy link
Member

alerque commented May 25, 2020

Anybody that does try to work on this should probably take a gander at #95 before getting started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants