[V15] User-defined Checkbox List only stores single item

[Ambertvu]

Which Contentment version are you using?

6.0.0-alpha004

Which Umbraco version are you using? For example: 13.2.1 - don't just write v13

V15.1.0

Bug summary

User-defined Checkbox List only stores single item. ModelsBuilder identifies is as a single string. (no enumerable)

Steps to reproduce

Create a composition and add the following datatype to it:

• Data List Property Editor UI (Contentment)
• User-defined List as Data source
• Checkbox List as List editor

Add two values to the user-defined list (for example x and y).

Select both. View value in frontend.

Expected result / actual result

Expected: Both values are shown as csv, or property is enumerable.

Actual: Property is a string, only the first item is shown.

Do you have Umbraco ModelsBuilder enabled?

• Yes, it is enabled.

What browsers are you seeing the problem on?

No response

[leekelleher]

@Ambertvu Thanks for reporting this. It had me stumped for a while, since the underlying C# code hasn't changed too much.

The bad news was that this bug applied to some other Data List editors too. 😖

The good news is that I have figured it out, and I do have a fix (in commit 2a43dbd). 🎉

The problem started when I migrated JSON deserialization from Newtonsoft to System.Text.Json. Turns out that with the built-in library, when deserializing a JsonObject to a Dictionary<string, object>, the object will be cast as the JsonElement ... which is different to how the Newtonsoft library handled it, so some parts of the Data List code made an assumption on the value types.

Anyway, hopefully my patch fixes this up, but if anything weird comes with related to configuration values, please do let me know.

I'm aiming to have a beta release out soon.