Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eddrit glitches #1030

Open
SkyRider13 opened this issue Dec 28, 2024 · 3 comments
Open

Eddrit glitches #1030

SkyRider13 opened this issue Dec 28, 2024 · 3 comments

Comments

@SkyRider13
Copy link

Hi the eddrit frontend for reddit itself works fine but whenever you click a link to another post(eddrit usually leaves the base reddit link untouched, this means things like reddit short urls work unlike Redlib) it only sometimes redirects automatically to edrrit. I have to manually tap the extension to do make it work myself very often.

I'd expect the redirection to work automatically as usual with the normal longer reddit links, hopefully short urls needing to redirect to a long link first could be left alone somehow?

@IkelAtomig
Copy link
Member

Well, if you see Redlib, afaik, they convert this shortlinks to reddit.com so we never bothered.

What are those shortlinks you mean, some examples ?

@SkyRider13
Copy link
Author

Redlib still uses their own shortlink which doesn't work, though that's more of a them problem than the extensions
image

As for eddrit, that does link to the normal reddit shortlinks
image

the issue is that sometimes after clicking it the extension doesn't redirect the loaded page to eddrit all the time

@IkelAtomig
Copy link
Member

As I said, we redirect the main page URL the rest is automatically converted by the frontend itself.

@ManeraKai - If you have this in regex, then look onto it and fix else, tag this upstream,won't fix and close as not planned.

@SkyRider13 - Sorry, this is a upstream bug. If it is not redirected even when included in the code. We will fix it. If not, this will be closed and please file it in eddrit repository reference this issue.

We mainly focus on redirecting links in the address bar, the rest is mostly handled by instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants