Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bilinear Upscaling missed #47

Closed
lodgerz opened this issue Jan 9, 2025 · 3 comments
Closed

Bilinear Upscaling missed #47

lodgerz opened this issue Jan 9, 2025 · 3 comments

Comments

@lodgerz
Copy link

lodgerz commented Jan 9, 2025

hello,
is this the git of the retroarch LRPS2 core? i wanted to ask if it is possible to add the pcsx2 "Bilinear Scaling" option to the core to improve the graphical aspect. thanks.

@LibretroAdmin
Copy link
Collaborator

LibretroAdmin commented Jan 9, 2025

Not sure what you mean by that, you mean gsdx or parallel-gs? Either way I think you need to do that on the frontend (i.e. RetroArch), the core shouldn't be doing any additional postprocessing on the raw output image before sending it off to the frontend.

So what you prob want is RetroArch -> Settings -> Scaling -> Bilinear Filtering -> ON/OFF.

If you meant gsdx, I have ripped the 'present' shaders out of gsdx completely because I don't want the additional overhead for something that should be done on the frontend side anyway. It also saves a bit on performance and latency this way too.

So yes, either way I think the answer is 'do it on the frontend side', this doesn't belong on the core end. The image should be raw as possible before sending it off to the frontend, and then the frontend will do the necessary extra scaling. Either apply whatever shader you want to do the bilinear scaling pass or just enable/disable that setting in RetroArch I stated before.

@lodgerz
Copy link
Author

lodgerz commented Jan 9, 2025

So what you prob want is RetroArch -> Settings -> Scaling -> Bilinear Filtering -> ON/OFF.

oh i didn't know that! i activated the Bilinear Filtering and now the video quality of the PS2 games is the same identical to pcsx2 stand-alone!
too bad that on retroarch you can't set the Bilinear Filtering for each single core (in 2d games I prefer not to use it)

thanks and congrats for this core, it works great!

@hizzlekizzle
Copy link
Collaborator

@lodgerz If you keep it turned off globally and then load LRPS2, then change the setting and go to quick menu > overrides > save core override, it will only apply it when the core is loaded and will leave it disabled everywhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants