Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Tests are failing with soundfile==0.13.0 #1895

Closed
matthiasdotsh opened this issue Jan 9, 2025 · 4 comments
Closed

[Bug]: Tests are failing with soundfile==0.13.0 #1895

matthiasdotsh opened this issue Jan 9, 2025 · 4 comments
Labels
Upstream/dependency bug Another package is causing us trouble!
Milestone

Comments

@matthiasdotsh
Copy link

matthiasdotsh commented Jan 9, 2025

Bug summary

While updating soundfile to 0.13.0 in nixpkgs, we found out that your tests are no longer passing latest soundfile version.

Code for reproduction

I forked librosa and can reproduce it with your CI scripts and pinned soundfile versions.

For 0.12.0 tests are passing.

for 0.13.0 tests are failing.

Actual outcome

Test are failing for sounfile==0.13.0

Expected outcome

Tests should pass regardless of the soundfile version.

Additional information

Might be related to this bugfix in soundfile.

Operating system

No response

software versions

Please see CI logs.

Installation

None

@bmcfee bmcfee added the bug Something doesn't work like it should label Jan 9, 2025
@bmcfee bmcfee added this to the 0.11.0 milestone Jan 9, 2025
@bmcfee
Copy link
Member

bmcfee commented Jan 9, 2025

Thanks for catching this. I'll try to work up a fix in the next few days.

@bmcfee
Copy link
Member

bmcfee commented Jan 13, 2025

Looking into this now - you are correct that this PR seems to have caused the change in behavior. What's not yet clear to me yet is whether the new behavior is a bug on our side or on soundfile's side - it looks to me like soundfile's new behavior may not be in line with their API spec, but I'll confer with the devs.

@bmcfee bmcfee added Upstream/dependency bug Another package is causing us trouble! and removed bug Something doesn't work like it should labels Jan 14, 2025
@bmcfee
Copy link
Member

bmcfee commented Jan 14, 2025

Have confirmed upstream that this is a regression in soundfile to be fixed, and not a bug on our side.

@bmcfee
Copy link
Member

bmcfee commented Jan 21, 2025

Fixed by bastibe/python-soundfile#457

@bmcfee bmcfee closed this as completed Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Upstream/dependency bug Another package is causing us trouble!
Development

No branches or pull requests

2 participants