time zone

[pietercolpaert]

Make sure that timezone is configurable or readable from the feed info

[pietercolpaert]

Right now, GTFS2LC always takes the system’s locale. If you want to parse a GTFS file, people should have the right locale timezone set on their system.

[derhuerst]

Heads up! GTFS Time values are not relative to midnight, but to noon - 12h.

gtfs2lc currently just adds the time to midnight. AFAICT, this will fail during DST <-> standard time shifts.

[derhuerst]

Make sure that timezone is configurable or readable from the feed info

Reading it from stops.stop_timezone & agency.agency_timezone would be the spec-compliant mechanism.

[pietercolpaert]

If it were a string concatenation it would have been problematic indeed, but it isn't. We took this into account!

[derhuerst]

If it were a string concatenation it would have been problematic indeed, but it isn't. We took this into account!

Are you sure? Because the code doesn't look like it.

I couldn't verify that it works because I failed to get gtfs2lc running, because of #113 and other issues.

[pietercolpaert]

Yes: it adds the duration since midnight to midnight of that date. I remember us bumping in that issue and making sure it’s correctly fixed. Feel free to reopen if you would see unexpected behaviour in your results. @julianrojas87 can you look into #113 so that @derhuerst can continue?

[derhuerst]

Just noticed that I had opened #110 for this, so no matter if it's actually an issue, we can discuss there.