Root on ZFS customizations to zsys-setup

[dan42]

I've installed Linux Mint using the ZFS option, and I find the default layout provided by the installer is really not good (rationale below) so I had to customize /usr/share/ubiquity/zsys-setup to produce something more usable.
script: zsys-setup
diff: zsys-setup.diff

And I think it would be good to contribute those changes upstream. I'd need to clean up the script a bit, but is anyone here interested in that? Is this the correct place to submit?

---

Why did I have to make changes to the ZFS layout?

For context, the default layout is

fat32 EFI    512 MiB
linux-swap   2 GiB
zfs bpool    2 GiB
zfs rpool    rest of disk

This is not good because (and this is the only downside of ZFS) it's not possible to resize ZFS partitions. So if you want to add more swap or dual boot, you can't. You're stuck. So I changed zsys-setup to produce this for my 2TiB NVMe drive:

fat32 EFI    512 MiB
zfs bpool    2 GiB
zfs rpool    500 GiB
linux-swap   2 GiB
unallocated  rest of disk

This leaves a bunch of unallocated space to be used how you wish. And if you want all that space in the rpool, you can easily create a second vdev and attach it to the rpool. In my case this is how I used the space:

fat32 EFI        512 MiB
zfs bpool        2 GiB
zfs rpool        500 GiB
zfs rpool(vdev2) 1.25 TiB
zfs SLOG(hdd)    32 GiB (SLOG for hdd pool separate from rpool)
linux-swap       64 GiB