Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] APP_LOCALE default should be en-US instead of en #71

Closed
1 task done
Tyree opened this issue Jun 17, 2024 · 4 comments
Closed
1 task done

[BUG] APP_LOCALE default should be en-US instead of en #71

Tyree opened this issue Jun 17, 2024 · 4 comments

Comments

@Tyree
Copy link

Tyree commented Jun 17, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

With the APP_LOCALE being set to en, the laravel logs will repeatedly spit out:
production.WARNING: APP_LOCALE in .env is set to en and should be updated to be en-US
As the warning indicates, I assume this only happens when in production mode.
Propose the default be set to en-US and the readme be updated to reflect this.
Thanks!

Expected Behavior

en being the default ENV setting for APP_LOCALE, no errors in logs (storage/logs/laravel.log)

Steps To Reproduce

  1. Leave APP_LOCALE set as default "en"
  2. Start container
  3. browse laravel logs under storage/logs/laravel.log

Environment

- OS: unRAID
- How docker service was installed: Community Apps

CPU architecture

x86-64

Docker creation

unRAID

Container logs

The container log does not show this error.
Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@Tyree
Copy link
Author

Tyree commented Jun 19, 2024

The official Snipe-It docs have now been updated to show en-US as the correct code for English (US).

@LinuxServer-CI
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@LinuxServer-CI LinuxServer-CI closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2024
@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker Sep 18, 2024
Copy link

This issue is locked due to inactivity

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

2 participants