Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic-loader #214

Open
liquidz opened this issue May 11, 2020 · 3 comments
Open

Support dynamic-loader #214

liquidz opened this issue May 11, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@liquidz
Copy link
Owner

liquidz commented May 11, 2020

nrepl/nrepl#185

liquidz added a commit that referenced this issue May 11, 2020
@liquidz liquidz added the enhancement New feature or request label May 11, 2020
liquidz added a commit that referenced this issue May 11, 2020
liquidz added a commit that referenced this issue Jun 28, 2020
liquidz added a commit that referenced this issue Jun 28, 2020
liquidz added a commit that referenced this issue Jun 28, 2020
liquidz added a commit that referenced this issue Jun 28, 2020
liquidz added a commit that referenced this issue Sep 4, 2020
liquidz added a commit that referenced this issue Sep 4, 2020
liquidz added a commit that referenced this issue Sep 4, 2020
liquidz added a commit that referenced this issue Sep 4, 2020
liquidz added a commit that referenced this issue Sep 4, 2020
@liquidz
Copy link
Owner Author

liquidz commented Sep 4, 2020

need to rethink how to use it in which situations and what value it provides.

@bbatsov
Copy link
Contributor

bbatsov commented Aug 26, 2021

For me the main use case it pretty-straightforward - you bundle all the Clojure deps (e.g. middleware) with the client package and the client loads those when it starts. This eliminates the need for you to craft special Lein/Boot/clj invocations to provide the deps in this manner.

More importantly, if the deps are packaged with the plugin, you can inject them in remote connections that you didn't start and that you don't control the dependencies of. This also makes it simpler for other plugins to load their library deps/middleware on the demand, without having to fiddle with the jack-in commands.

@Cnly
Copy link
Contributor

Cnly commented Dec 18, 2021

This will be a super useful feature! Especially when iced needs its own middleware in addition to cider-nrepl (which I expect to be found in most places with nrepl). Supporting dynamic middleware loading will make it possible for iced to connect to basically every running nREPL instances.

For the downsides, I learned from this article https://lambdaisland.com/blog/2021-11-24-making-nrepl-cider-more-dynamic-2 that sideloading may hurt performance if the nREPL connection is not local. Nevertheless, the ability to connect to running servers without modifying its dependencies would still outweigh the drawback, IMO.

After taking a look at iced-nrepl, I also found it's basically independent from other cider-nrepl or nrepl features. So maybe another way to obtain the ability is to make a "proxy" connection, i.e. vim-iced will spawn an iced-nrepl process, which will handle all iced-specific ops locally, and forward everything else to the remote cider-nrepl instance?

liquidz added a commit that referenced this issue Oct 1, 2022
liquidz added a commit that referenced this issue Oct 1, 2022
liquidz added a commit that referenced this issue Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants