[clang-tidy] Add AllowedTypes option to misc-const-correctness

[vbvictor]

Sometimes in large codebases we want to ignore const-correctness of certain classes because they are immutable by nature, so there is no point in adding const to them.
Minimal example:

#include <mutex>

int main() {
  std::mutex m;
  std::lock_guard<std::mutex> l(m); // check is triggered but we want to ignore it since lock_guard is already immutable.
}

Writing NOLINT for thousands of places bloats code and is not an appealing option.

[llvmbot]

@llvm/issue-subscribers-clang-tidy

Author: Baranov Victor (vbvictor)

Sometimes in large codebases we want to ignore const-correctness of certain classes because they are immutable by nature, so there is no point in adding const to them. Minimal example:

#include <mutex>

int main() {
  std::mutex m;
  std::lock_guard<std::mutex> l(m); // check is triggered but we want to ignore it since lock_guard is already immutable.
}

Writing NOLINT for thousands of places bloats code and is not an appealing option.

[vbvictor]

Can this issue be assigned to me if it is a good improvement

[firewave]

There is #58084 which is somewhat related by adding an option to only report it for POD types.

[vbvictor]

There is #58084 which is somewhat related by adding an option to only report it for POD types.

This option may help with my particular case with std::lock_guard however, I think narrowing to POD types may be too strict for some users, including me.

[firewave]

This option may help with my particular case with std::lock_guard however, I think narrowing to POD types may be too strict for some users, including me.

See all my notes in the other ticket what the actual intention is. The title is a bit misleading.