Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we have a plan for resolving seniority when two users were added concurrently #68

Open
HerbCaudill opened this issue Nov 19, 2023 · 0 comments

Comments

@HerbCaudill
Copy link
Member

In the bySeniority sort function, we just check if a is a predecessor of b and if not, we assume that b is a predecessor of a. But they could have been added concurrently, in which case I'm not sure the current behavior is deterministic.

Test plan:

  • Two users are admitted concurrently.
  • They're both promoted to admins.
  • They try to remove each other concurrently.
  • Assert that everyone on the team resolves the conflict the same way
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant