Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version v0.0.13 breaks on Windows #30

Open
siccous opened this issue Jun 11, 2024 · 10 comments
Open

version v0.0.13 breaks on Windows #30

siccous opened this issue Jun 11, 2024 · 10 comments

Comments

@siccous
Copy link

siccous commented Jun 11, 2024

Hello,

we can't connect through SSH after upgrading to version v0.0.13+

OS is Windows and the result is:

image

Please make sure you have configured the correct SSH host and the following command can be executed on your system:
ssh -oStrictHostKeyChecking=no -oBatchMode=yes xxx@xxx echo Devpod Test
Try enabling Debug mode under Settings to see a more verbose output
init: exit status 1

This doesn't happen in v0.0.12.

Thanks

@pascalbreuninger
Copy link
Member

@siccous Thanks for opening this issue. Could you provide more details about your setup please?

@siccous
Copy link
Author

siccous commented Jun 12, 2024

Hello Pascal,

first of all sorry for my lacking issue description :)

Already did my digging properly and the reason why it doesn't work for us is your PR #27

As you specified in the PR description we need to use an identity file now, that's little bit unlucky because we use ssh-agent.

Why was this PR and the switch to internal Go SSH implementation needed? We use DevPod with SSH provider on Windows daily and never encountered any issue which you describe in your PR.

@pascalbreuninger
Copy link
Member

pascalbreuninger commented Jun 12, 2024

Already did my digging properly and the reason why it doesn't work for us is your PR #27
As you specified in the PR description we need to use an identity file now, that's little bit unlucky because we use ssh-agent.

Ah I see, thanks for digging into it!
Would you be fine with an SSH_IDENTITY_FILE option in the provider to manually specify the path?

Why was this PR and the switch to internal Go SSH implementation needed?

The SSH provider didn't work on an out-of-the box windows 10 and 11 installation, therefore we had to switch. May I ask which ssh client you are using?

@siccous
Copy link
Author

siccous commented Jun 12, 2024

Ah I see, thanks for digging into it!
Would you be fine with an SSH_IDENTITY_FILE option in the provider to manually specify the path?

Of course that would be much better for the end user.

But rather I would like to help you to solve the issues you encountered, because we use the SSH provider on Windows many months without any issues.

The SSH provider didn't work on an out-of-the box windows 10 and 11 installation, therefore we had to switch. May I ask which ssh client you are using?

It works for us :)

SSH - OpenSSH_for_Windows_8.6p1, LibreSSL 3.3.3
Devpod - 0.5.13
SSH provider - 0.0.12

SSH keys are added through the Windows native service OpenSSH Authentication Agent.

We are connecting to regular Debian 12 servers (only special thing is using FreeIPA on them) and it works out of the box.

I will gladly provide any other logs, details, etc...

@siccous
Copy link
Author

siccous commented Jul 2, 2024

@pascalbreuninger any news? Can I help you somehow or should I create our own fork of ssh provider?

@pascalbreuninger
Copy link
Member

Hey @siccous, the solution is relatively straightforward, we just need to find the time for it :)
If you want to speed it up you could give it a go yourself

@siccous
Copy link
Author

siccous commented Jul 3, 2024

@pascalbreuninger I would like to help, but as I described it before the issue doesn't happen for us :)

Can you please try to describe it from your end? Versions, environment, etc...

@omniproc
Copy link

omniproc commented Jul 9, 2024

can confirm. same issue here with 0.0.14. not getting the error with version 0.0.12.
Running on Windows 10 22H2 Build 19045.4529 with OpenSSH_for_Windows_8.1p1, LibreSSL 3.0.2 and also using the Windows built-in openssh-agent for key management. SSH config looks like this:

  HostName myhost.com
  User username
  ForwardAgent yes
  MACs hmac-sha2-512
  IdentityFile "C:\Users\me\.ssh\my-rsa.key"

Which works perfectly fine to execute the command requested in the error message ssh -oStrictHostKeyChecking=no -oBatchMode=yes xxx@xxx echo Devpod Test.

DevPod version is v.0.5.16

@pascalbreuninger
Copy link
Member

@siccous @omniproc I've rolled back the changes of always using the builtin ssh client on windows (see #32).
This is now configurable through the USE_BUILTIN_SSH provider option and disabled by default.

Hope this helps 👍

@Falcon7382
Copy link

Can confirm enabling 'Use Builtin SSH' within the Provider Settings resolved this issue for me. Thanks!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants