Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rv_dm] havereset may assert at incorrect time #19502

Closed
a-will opened this issue Aug 22, 2023 · 3 comments
Closed

[rv_dm] havereset may assert at incorrect time #19502

a-will opened this issue Aug 22, 2023 · 3 comments
Assignees
Labels
Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones

Comments

@a-will
Copy link
Contributor

a-will commented Aug 22, 2023

Description

It appears havereset asserts when an NDM reset begins:

// set the havereset flag when we did a ndmreset
if (ndmreset_o) begin
havereset_d_aligned[NrHarts-1:0] = '1;
end

This does not follow spec. havereset should only assert once the reset completes, and it may be used as a synchronization point for the debugger. It's not used in openocd upstream yet (where there is a bug with merely checking allunavail), but it is properly checked in riscv-openocd.

@a-will a-will self-assigned this Aug 22, 2023
@a-will
Copy link
Contributor Author

a-will commented Aug 22, 2023

CC @msfschaffner @andreaskurth

@msfschaffner
Copy link
Contributor

CC @GregAC

@msfschaffner msfschaffner added the Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones label Oct 9, 2023
@msfschaffner msfschaffner added this to the Earlgrey-PROD.M2 milestone Nov 7, 2023
@a-will
Copy link
Contributor Author

a-will commented Dec 1, 2023

Oh, this is a duplicate, it turns out.

Same issue as the following:
#15123
pulp-platform/riscv-dbg#118

@a-will a-will closed this as not planned Won't fix, can't repro, duplicate, stale Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones
Projects
None yet
Development

No branches or pull requests

2 participants