Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the transpose #8

Open
lu-zero opened this issue Oct 18, 2016 · 11 comments
Open

Implement the transpose #8

lu-zero opened this issue Oct 18, 2016 · 11 comments

Comments

@lu-zero
Copy link
Owner

lu-zero commented Oct 18, 2016

No description provided.

@shawnpringle
Copy link

Hello @lu-zero. I have created a pull request for this issue #14 . You can use simple_decode.c to decode and transopose a video to raw frames.

I found that the vpx images need more memory than they are allocated for at times for some formats. So the test program avoids vpx_img_alloc.

@lu-zero
Copy link
Owner Author

lu-zero commented Oct 28, 2016

I'm afraid you misunderstood the whole set of issues. This list of issues (that is mainly my todo, so does not have much information) is about VSX and libvpx.

@shawnpringle
Copy link

shawnpringle commented Oct 28, 2016

okay. so let's start over. I think these are therequirements now: Routines Must use VSX instructions The routines must work in place but they can be for fixed sized square planes. For what sized planes must they be and how many routines?

@shawnpringle
Copy link

There is a macro in vpx_dsp/x86/inv_txfm_ssse3_x86_64.asm
Are you looking for a VSX version of this?

    %macro TRANSPOSE8X8 9
      INTERLEAVE_2X  wd, %1, %2, %9
      INTERLEAVE_2X  wd, %3, %4, %9
      INTERLEAVE_2X  wd, %5, %6, %9
      INTERLEAVE_2X  wd, %7, %8, %9

      INTERLEAVE_2X  dq, %1, %3, %9
      INTERLEAVE_2X  dq, %2, %4, %9
      INTERLEAVE_2X  dq, %5, %7, %9
      INTERLEAVE_2X  dq, %6, %8, %9

      INTERLEAVE_2X  qdq, %1, %5, %9
      INTERLEAVE_2X  qdq, %3, %7, %9
      INTERLEAVE_2X  qdq, %2, %6, %9
      INTERLEAVE_2X  qdq, %4, %8, %9

      SWAP  %2, %5
      SWAP  %4, %7
    %endmacro

@shawnpringle
Copy link

shawnpringle commented Nov 10, 2016

Is this what is wanted? Anyone? Transpose16x16 macro that work for 8 bitdepth images and a transpose8x8 macro that is for high depth images. Both implemented in Altivec instructions. Please respond.

@lu-zero
Copy link
Owner Author

lu-zero commented Nov 10, 2016

I hate repeating myself: this issue is not what you have in mind, you cannot start working on it without working on the other issues before.

Your behavior in the pull request managed to upset even @edelsohn and I really do not have time to teach you what is all about.

@shawnl
Copy link

shawnl commented May 15, 2019

This was fixed in dc93b62 by Luc Trudeau luc@trud.ca
@luctrudeau He should get the bounty.

@rafaeldelucena
Copy link
Collaborator

rafaeldelucena commented Jun 19, 2019

Actually the first transpose implementation for 8x8 matrix was added 405b94c committed at Oct 19, 2016.

But I do not know if only implementing the transpose for 8x8 signed int16 is enough to close the issue.

@shawnpringle
Copy link

shawnpringle commented Jun 24, 2019 via email

@shawnl
Copy link

shawnl commented Jun 24, 2019

@shawnpringle If they don't use your code, they don't owe you the bounty. Until that point you have not licensed the code under the project's license and have exclusive monopoly over the copying thereof. It is very simple, and would not work any other way. You wrote that code 2 years ago, and certainly have had time to try again, and with more respect.

@shawnpringle
Copy link

shawnpringle commented Jun 24, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants