required validation for file is not executed

[kchobantonov]

Sorting

• I'm submitting a ...

  • [ X] bug report
  • feature request
  • support request

• I confirm that I

  • [X ] used the search to make sure that a similar issue hasn't already been submit

Expected Behavior

Should get a validation error response for required file/files

Current Behavior

No validation is performed when the file(s) is not provided.

Possible Solution

In expressTemplateService.ts do not immediately return undefined when the parameter is not found - like this code

if (requestFiles[name] === undefined) {
  return undefined;
}

Steps to Reproduce

Define the controller method as

  @Post('File')
  public async postWithFile(@UploadedFile('someFile') aFile: File): Promise<File> {
    return aFile;
  }

2. execute a request again the /File without providing the someFile field in the request
3. Check that not validation is performed

Context (Environment)

Version of the library: 6.6.0
Version of NodeJS: v18.19.0

• Confirm you were using yarn not npm: [ x]

Detailed Description

Will provide a pull request shortly with the actual changes.

Breaking change?

[github-actions]

Hello there kchobantonov 👋

Thank you for opening your very first issue in this project.

We will try to get back to you as soon as we can.👀

[kchobantonov]

fixed by #1739