From d5ef2260c22a3c6c41ae113418ebcdd164ff3e4a Mon Sep 17 00:00:00 2001 From: Tiffany Chiang Date: Thu, 7 Nov 2024 18:05:37 -0500 Subject: [PATCH] noted TODO: current deploy checkrun is updated twice on confirm/reject apply (once with empty Result, once with Result filled in --- server/neptune/workflows/internal/deploy/terraform/state.go | 1 + 1 file changed, 1 insertion(+) diff --git a/server/neptune/workflows/internal/deploy/terraform/state.go b/server/neptune/workflows/internal/deploy/terraform/state.go index c38524753..2b621395b 100644 --- a/server/neptune/workflows/internal/deploy/terraform/state.go +++ b/server/neptune/workflows/internal/deploy/terraform/state.go @@ -49,6 +49,7 @@ func (n *StateReceiver) Receive(ctx workflow.Context, c workflow.ReceiveChannel, } } // Updates github check run with Terraform statuses for the current running deployment + // TODO: do not notify github if workflowState.Result.Status == InProgressWorkflowStatus && workflowState.Result.Reason == UnknownCompletionReason for _, notifier := range n.InternalNotifiers { if err := notifier.Notify(ctx, deploymentInfo.ToInternalInfo(), workflowState); err != nil { workflow.GetMetricsHandler(ctx).Counter("notifier_failure").Inc(1)