Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Runner with VS2022 Preview dotnet 9 #527

Open
mynkow opened this issue Sep 29, 2024 · 7 comments
Open

Test Runner with VS2022 Preview dotnet 9 #527

mynkow opened this issue Sep 29, 2024 · 7 comments

Comments

@mynkow
Copy link

mynkow commented Sep 29, 2024

Has anyone a success running tests within VS2022 Preview with dotnet 9?

@mikeblakeuk
Copy link
Contributor

Using VS2022, .net 9.0.100

In some projects I get issues as it's using NETStandard.Library 1.6.1
In other projects it uses NETStandard.Library 2.0.1

image
and so get
error NU1903: Warning As Error: Package 'System.Text.RegularExpressions' 4.3.0 has a known high severity vulnerability,

I wonder if we should target net8?

@mikeblakeuk
Copy link
Contributor

It works if you add <NuGetAuditMode>direct</NuGetAuditMode>

I use R# Runner.

The only thing is the code looks obsolete (light grey).
image

@robertcoltheart
Copy link
Member

I'll take a look, it's likely we just need to target netstandard2.0

@jnyrup
Copy link

jnyrup commented Dec 18, 2024

I'll take a look, it's likely we just need to target netstandard2.0

I had a look and locally this commit seemed sufficient. jnyrup@8239700
It also tries to account for netstandard2.0 having more capabilities than netstandard1.3.
I have no idea if it builds clean with the VS2017 used in the CI for the release/1.0.0 tag.

@mikeblakeuk
Copy link
Contributor

based on the master branch they target
<TargetFrameworks>net472;net6.0</TargetFrameworks>
except the
Machine.Specifications.Analyzers.csproj

Not sure if that is the issue.

@robertcoltheart
Copy link
Member

Master branch is in flux at the moment after ignoring it for a long time.

@mikeblakeuk
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants