From 36a782556945871b367551219a0b4617392b570f Mon Sep 17 00:00:00 2001 From: Jon Harmon Date: Fri, 2 Jun 2023 10:07:30 -0500 Subject: [PATCH] Perform checks for CRAN. (#21) Also see previous PR for the actual changes. Sorry about that, I'm out of practice (as far as working with a reviewer)! --- .Rbuildignore | 1 + NEWS.md | 4 ++++ cran-comments.md | 35 +++++++++++++++++++++++++++-------- revdep/.gitignore | 7 +++++++ revdep/README.md | 32 ++++++++++++++++++++++++++++++++ revdep/cran.md | 7 +++++++ revdep/email.yml | 5 +++++ revdep/failures.md | 1 + revdep/problems.md | 1 + 9 files changed, 85 insertions(+), 8 deletions(-) create mode 100644 revdep/.gitignore create mode 100644 revdep/README.md create mode 100644 revdep/cran.md create mode 100644 revdep/email.yml create mode 100644 revdep/failures.md create mode 100644 revdep/problems.md diff --git a/.Rbuildignore b/.Rbuildignore index d2f0ad1..29654ca 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -10,3 +10,4 @@ ^_pkgdown\.yml$ ^docs$ ^pkgdown$ +^revdep$ diff --git a/NEWS.md b/NEWS.md index 035749d..9b082bb 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,7 @@ +# piecemaker 1.0.2 + +* Streamlined `validate_utf8()` to work consistently across OS and R versions. + # piecemaker 1.0.1 * Removed purrr dependency. diff --git a/cran-comments.md b/cran-comments.md index be7f17b..01fd3ae 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -2,30 +2,49 @@ ## Changes -* Removed purrr dependency. +* Streamlined `validate_utf8()` to work consistently across OS and R versions. + +## R CMD check results + +0 errors | 0 warnings | 0 notes ## Test environments -* local R installation, R 4.1.2 (Windows 10) +* local R installation, R 4.3.0 (Windows 11) * win-builder (devel) * Windows Server 2022, R-devel, 64 bit (rhub) * Ubuntu Linux 20.04.1 LTS, R-release, GCC (rhub) * Fedora Linux, R-devel, clang, gfortran (rhub) -There is a NOTE when testing for Windows Server: +### Windows + +There are NOTEs when testing for Windows Server: ``` +* checking for non-standard things in the check directory ... NOTE +Found the following files/directories: + ''NULL'' * checking for detritus in the temp directory ... NOTE Found the following files/directories: 'lastMiKTeXException' ``` -I cannot reproduce this error on my Windows machine, and a web search indicated that it is likely nothing. I can't find anything that could possibly trigger that error. +I cannot reproduce these errors on my Windows machine, and a web search indicated that it is likely nothing. I can't find anything that could possibly trigger that error. -## R CMD check results +### Linux -0 errors | 0 warnings | 0 notes +Both Linux checks also returned this note: + +``` +* checking HTML version of manual ... NOTE +Skipping checking HTML validation: no command 'tidy' found +``` + +This note also appears to be a false alarm. + +## revdepcheck results -## Reverse dependencies +We checked 2 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package. -wordpiece and morphemepiece are not impacted by this change. + * We saw 0 new problems + * We failed to check 0 packages diff --git a/revdep/.gitignore b/revdep/.gitignore new file mode 100644 index 0000000..111ab32 --- /dev/null +++ b/revdep/.gitignore @@ -0,0 +1,7 @@ +checks +library +checks.noindex +library.noindex +cloud.noindex +data.sqlite +*.html diff --git a/revdep/README.md b/revdep/README.md new file mode 100644 index 0000000..64a71ed --- /dev/null +++ b/revdep/README.md @@ -0,0 +1,32 @@ +# Platform + +|field |value | +|:--------|:--------------------------------------| +|version |R version 4.3.0 (2023-04-21 ucrt) | +|os |Windows 11 x64 (build 22621) | +|system |x86_64, mingw32 | +|ui |RStudio | +|language |(EN) | +|collate |English_United States.utf8 | +|ctype |English_United States.utf8 | +|tz |America/Chicago | +|date |2023-06-01 | +|rstudio |2023.03.1+446 Cherry Blossom (desktop) | +|pandoc |NA | + +# Dependencies + +|package |old |new |Δ | +|:----------|:------|:------|:--| +|piecemaker |1.0.1 |1.0.2 |* | +|cli |3.6.1 |3.6.1 | | +|glue |1.6.2 |1.6.2 | | +|lifecycle |1.0.3 |1.0.3 | | +|magrittr |2.0.3 |2.0.3 | | +|rlang |1.1.1 |1.1.1 | | +|stringi |1.7.12 |1.7.12 | | +|stringr |1.5.0 |1.5.0 | | +|vctrs |0.6.2 |0.6.2 | | + +# Revdeps + diff --git a/revdep/cran.md b/revdep/cran.md new file mode 100644 index 0000000..d07935b --- /dev/null +++ b/revdep/cran.md @@ -0,0 +1,7 @@ +## revdepcheck results + +We checked 2 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package. + + * We saw 0 new problems + * We failed to check 0 packages + diff --git a/revdep/email.yml b/revdep/email.yml new file mode 100644 index 0000000..0c5cef8 --- /dev/null +++ b/revdep/email.yml @@ -0,0 +1,5 @@ +release_date: ??? +rel_release_date: ??? +my_news_url: ??? +release_version: ??? +release_details: ??? diff --git a/revdep/failures.md b/revdep/failures.md new file mode 100644 index 0000000..9a20736 --- /dev/null +++ b/revdep/failures.md @@ -0,0 +1 @@ +*Wow, no problems at all. :)* \ No newline at end of file diff --git a/revdep/problems.md b/revdep/problems.md new file mode 100644 index 0000000..9a20736 --- /dev/null +++ b/revdep/problems.md @@ -0,0 +1 @@ +*Wow, no problems at all. :)* \ No newline at end of file