Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When can we expect Strapi 5 support? #2

Open
dimitrisganotis opened this issue Oct 1, 2024 · 5 comments
Open

When can we expect Strapi 5 support? #2

dimitrisganotis opened this issue Oct 1, 2024 · 5 comments

Comments

@dimitrisganotis
Copy link

Is there a target date for the plugin update to support Strapi 5?

@m7rlin
Copy link
Member

m7rlin commented Oct 1, 2024

Hi @dimitrisganotis,

Thanks for reaching out! Strapi v5 was recently released, and I plan to wait at least 2 months before updating the plugin to v5 myself. This will allow time for any initial bugs or issues in the new version to be resolved, ensuring a smoother transition.

In the meantime, you're more than welcome to contribute to the project by creating a new branch for Strapi 5 support. Contributions are always appreciated!

Best regards,
m7rlin

@zhawzid-ottj
Copy link

zhawzid-ottj commented Oct 7, 2024

Doesn't seem to be too challenging, take a look at the one existing fork of this project (cezarvrabie99).
The only breaking change is, you need to use a different request parameter with Strapi v5.

I don't understand why team Strapi is blocking this. Looking at the code it isn't too expensive for performance as it should immediately return if the param isn't availabe (see fork code) or the model doesn't match the allowed models. There is still some performance optimization possible for the latter case in the current code - which is worth it, as other models like permission stuff are queried among every request.

Many devs like me use deep (or unpredictably deep) nested structures and I couldn't do my projects without an extension like this...

Some other fix:

- event.params.populate = true
+ event.params.populate = {}

@killthekitten
Copy link

There is a fork on NPM that piggybacks your repo name, which I found super confusing. Is it possible to merge their changes back to this repo and/or take down the package? Not sure if it's legit:

https://www.npmjs.com/package/magictm-strapi-v5-plugin-deep-populate

@at-woutervanderschagt
Copy link

Requesting the same, v5.x support :) just wondering if there's an update on the timeline?

@m7rlin
Copy link
Member

m7rlin commented Dec 5, 2024

Requesting the same, v5.x support :) just wondering if there's an update on the timeline?

January 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants