Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renable jscpd for HTML files #15

Open
thewildmage opened this issue Feb 25, 2022 · 0 comments
Open

Renable jscpd for HTML files #15

thewildmage opened this issue Feb 25, 2022 · 0 comments
Assignees
Labels
enhancement Improvements, refactors, or updated iterations

Comments

@thewildmage
Copy link
Member

Because I'm writing the HTML by hand and not using any sort of templating, there's duplicate code and it's tripping jscpd during Super-Linter runs. I've disabled jscpd for .html files, but it would be great to get this to a place where I can re-enable it in the future.

@thewildmage thewildmage added the enhancement Improvements, refactors, or updated iterations label Feb 25, 2022
@thewildmage thewildmage self-assigned this Feb 25, 2022
thewildmage added a commit that referenced this issue Feb 25, 2022
opened #15 to come back to this in the future
thewildmage added a commit that referenced this issue Feb 25, 2022
* add html for edit form

* update id naming convention to put form type first

* create and wire in edit-handler.js

* move redundant methods to webhook-handler.js

* convert ConditionalInput to class to separate instances
previously instances were pointing to same object and interfering with each other

* disable jscpd for HTML files
opened #15 to come back to this in the future
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements, refactors, or updated iterations
Projects
None yet
Development

No branches or pull requests

1 participant