Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embroider compatibility #42

Open
dbendaou opened this issue Oct 7, 2021 · 2 comments · May be fixed by #54
Open

Embroider compatibility #42

dbendaou opened this issue Oct 7, 2021 · 2 comments · May be fixed by #54

Comments

@dbendaou
Copy link

dbendaou commented Oct 7, 2021

It seems that the addon cannot be run with Embroider.
Indeed, I have the following error in my test
Screenshot 2021-10-07 at 17 48 05

I would say that it's caused by the fact that we're renaming the import path of the addon from
ember-power-calendar-date-fns to ember-power-calendar-util but I'm not sure how we could fix that

@Techn1x
Copy link

Techn1x commented Apr 11, 2023

I think a great first step to upgrading this plugin would be to use the moment & luxon plugins as a guide, which are much more up to date (eg ember-auto-import v2), and also seem way simpler (eg only exporting a single index.js and using broccoli-funnel to move to xxx-utils, no use of string-replace)
https://github.com/cibernox/ember-power-calendar-moment
https://github.com/cibernox/ember-power-calendar-luxon

cc @cibernox

@Techn1x
Copy link

Techn1x commented Apr 11, 2023

cc @makepanic if you're still around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants