Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error occurs when adding fields with the same name #47

Open
carlineng opened this issue Nov 17, 2022 · 4 comments
Open

Error occurs when adding fields with the same name #47

carlineng opened this issue Nov 17, 2022 · 4 comments

Comments

@carlineng
Copy link

Using the Baby Names example, first add gender, then add cohort.gender:
image

Composer crashes with the error Ambiguous output field name:
image

@christopherswenson
Copy link
Contributor

Great catch — thanks for filing the issue. The language doesn't allow for multiple fields with the same "output" name in a query (gender and cohort.gender both have the same output name), and gives that error "Ambiguous output field name." if you try.

Probably the UI should force you to rename one of them if you try to do this.

@christopherswenson
Copy link
Contributor

Independent of the fix, we should probably catch errors that result from bad generated queries and handle them more gracefully...

@whscullin
Copy link
Contributor

Splitting unhandled exception out to #54

@whscullin whscullin changed the title Crash occurs when adding fields with the same name Error occurs when adding fields with the same name Nov 17, 2022
@tschomer
Copy link

tschomer commented Dec 6, 2022

perhaps we could rename things, so this works without the user having to figure things out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants