Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional commands for all pxm boolean #11

Open
perrygeo opened this issue Nov 11, 2015 · 2 comments
Open

Additional commands for all pxm boolean #11

perrygeo opened this issue Nov 11, 2015 · 2 comments

Comments

@perrygeo
Copy link
Contributor

perrygeo commented Nov 11, 2015

Right now pxm has bash scripts, python scripts, external python commands and bash functions to assert various things about raster data. All of these methods have slightly different modes of operation (some raise exceptions, some return a special value, some use exit codes, etc) and are not very easy to test.

I'd like to move all the boolean tests from pxm to subcommands of raster-tester. Basically anytime we need to ask a yes/no question about a raster or set of rasters, this command should be the place to go.

So far we have

  • compare
  • isempty

But we could pull in

  • aligned
  • crosses-dateline
  • is_evil
  • is_lossy
  • validate

This would also give us an opportunity to define and standardize exactly what a Yes/No response should look like and how the bash scripts should handle them

  • exit codes
  • what gets output to stdout/stderr
@perrygeo
Copy link
Contributor Author

perrygeo commented Dec 1, 2015

whacky idea: what if we made this into a pair of rio scripts: rio isit and rio arethey and used options to specify multiple attributes to test (rather than having subcommands for everything).

So instead of raster-tester isempty blah.tif we would have rio isit --empty blah.tif and we could chain it together with other tests like rio isit --empty --happy --not-crosses-dateline blah.tif

@jqtrde
Copy link
Contributor

jqtrde commented Dec 1, 2015

Without thinking too deeply about any of the implications, this seems like an awesome approach. Makes it a little easier to understand just what we're testing for. The syntax is 👌 imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants